ensure task delete when podsandbox run failed#12397
Open
yylt wants to merge 1 commit intocontainerd:mainfrom
Open
ensure task delete when podsandbox run failed#12397yylt wants to merge 1 commit intocontainerd:mainfrom
yylt wants to merge 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: yang yang <[email protected]>
Contributor
Author
Contributor
|
can you explain how it works？ @yylt |
fuweid
reviewed
Oct 23, 2025
| @@ -209,7 +209,8 @@ func (c *Controller) Start(ctx context.Context, id string) (cin sandbox.Controll | |||
| if cleanupErr = container.Delete(deferCtx, containerd.WithSnapshotCleanup); cleanupErr != nil { | |||
Member
There was a problem hiding this comment.
This function is only invoked when task has been deleted. so, it's probably not that case you mentioned.
Maybe we should keep that container only if it fails to delete container.
Contributor
Author
There was a problem hiding this comment.
no... task delete will append defer function after NewTask success.
After setting to nil upon successful deletion, may encounter the leak you described in the issue #8981, regarding the "not found" error.
Member
There was a problem hiding this comment.
I think we should add failpoint test case to verify it. We probably need to check task service as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12344
when executing NewTask in the
podsandbox run, it may fail for various reasons, like timeout, ctx cancle .etc, and the shim process has already started.During the defer cleanup, cleaning up the podsandbox.container only deletes the data in the store and cannot guarantee that the task is properly deleted.
Therefore, it is necessary to retain the podsandbox.container, And task can be actively cleaned up through shutdown api. But the invocation of the task depends on the container information, so keep podsandbox.container even if cleanup done.
There is no guarantee that the NewTask operation is atomic. A failure does not mean that resources have been completely cleaned up. Therefore, it is reasonable to delegate cleanup to the upper caller