Add rlimits to service file#1846
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Dec 1, 2017
Merged
Conversation
Signed-off-by: Michael Crosby <[email protected]>
Member
|
The unit file we use for docker has this set, too. Will do it for containerd. |
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
==========================================
- Coverage 52.53% 49.13% -3.41%
==========================================
Files 78 86 +8
Lines 6683 8245 +1562
==========================================
+ Hits 3511 4051 +540
- Misses 2505 3524 +1019
- Partials 667 670 +3
Continue to review full report at Codecov.
|
Member
|
LGTM I'll let @crosbymichael decide if he wants to add the suggestions from @Random-Liu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby [email protected]