Merged
Conversation
Closes containerd#3201 Signed-off-by: Michael Crosby <[email protected]>
Member
|
LGTM |
dmcgowan
approved these changes
Apr 11, 2019
NicolasT
added a commit
to scality/metalk8s
that referenced
this pull request
Sep 25, 2019
The default 'open files' limit, 1024, is way too low for some of our applications. Since there's no way to bump this limit from within a container, and the artificial limit of 1024 file descriptors stems from an era where FDs were costly, bump the limit to a more reasonable (in 2019) default. Fixes: #1785 See: #1785 See: containerd/containerd#3201 See: containerd/containerd#3202
NicolasT
added a commit
to scality/metalk8s
that referenced
this pull request
Sep 25, 2019
The default 'open files' limit, 1024, is way too low for some of our applications. Since there's no way to bump this limit from within a container, and the artificial limit of 1024 file descriptors stems from an era where FDs were costly, bump the limit to a more reasonable (in 2019) default. Manual test: ``` [root@bootstrap ~]# kubectl taint node bootstrap node-role.kubernetes.io/bootstrap- node/bootstrap untainted [root@bootstrap ~]# kubectl taint node bootstrap node-role.kubernetes.io/infra- node/bootstrap untainted [root@bootstrap ~]# kubectl run --restart=Never --image=busybox shell -- sleep 9999 pod/shell created [root@bootstrap ~]# kubectl exec -ti shell -- sh -c 'ulimit -n' 1048576 ``` Fixes: #1785 See: #1785 See: containerd/containerd#3201 See: containerd/containerd#3202
NicolasT
added a commit
to scality/metalk8s
that referenced
this pull request
Sep 26, 2019
The default 'open files' limit, 1024, is way too low for some of our applications. Since there's no way to bump this limit from within a container, and the artificial limit of 1024 file descriptors stems from an era where FDs were costly, bump the limit to a more reasonable (in 2019) default. Manual test: ``` [root@bootstrap ~]# kubectl taint node bootstrap node-role.kubernetes.io/bootstrap- node/bootstrap untainted [root@bootstrap ~]# kubectl taint node bootstrap node-role.kubernetes.io/infra- node/bootstrap untainted [root@bootstrap ~]# kubectl run --restart=Never --image=busybox shell -- sleep 9999 pod/shell created [root@bootstrap ~]# kubectl exec -ti shell -- sh -c 'ulimit -n' 1048576 ``` Fixes: #1785 See: #1785 See: containerd/containerd#3201 See: containerd/containerd#3202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3201
Signed-off-by: Michael Crosby [email protected]