Fix seccomp contributed profile for clone syscall#3314
Merged
estesp merged 1 commit intocontainerd:masterfrom Jun 3, 2019
Merged
Fix seccomp contributed profile for clone syscall#3314estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
32bfa60 to
add4120
Compare
|
Build succeeded.
|
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
add4120 to
1442839
Compare
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3314 +/- ##
======================================
Coverage 44.6% 44.6%
======================================
Files 112 112
Lines 12180 12180
======================================
Hits 5433 5433
Misses 5913 5913
Partials 834 834
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3314 +/- ##
======================================
Coverage 44.6% 44.6%
======================================
Files 112 112
Lines 12180 12180
======================================
Hits 5433 5433
Misses 5913 5913
Partials 834 834
Continue to review full report at Codecov.
|
Member
|
This looks reasonable; however, given this is contributed content ( Thanks! |
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
1442839 to
f811b4a
Compare
KentaTada
changed the title
|
Build succeeded.
|
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
f811b4a to
30bdb45
Compare
|
Build succeeded.
|
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
30bdb45 to
c3b49b6
Compare
|
Build succeeded.
|
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
c3b49b6 to
767d5f4
Compare
|
Build succeeded.
|
All clone flags for namespace should be denied. Also x/sys should be used instead of syscall. Signed-off-by: Kenta Tada <[email protected]>
KentaTada
force-pushed
the
fix-clone-seccomp-cgroupns
branch
from
767d5f4 to
5b9a43d
Compare
|
Build succeeded.
|
Contributor
Author
|
@estesp Thank you for the review. I changed the title and comment. Could you confirm it? |
Member
|
LGTM |
Member
|
@KentaTada could you check if changes are needed to the default seccomp profile in moby/moby? https://github.com/moby/moby/blob/61da822eeb7905a61eeaf18ea386e1a786cf0601/profiles/seccomp/seccomp_default.go#L517-L538 |
Member
|
@justincormack ptal |
Contributor
|
@thaJeztah yes the changes should be the same on moby/moby |
Member
|
Thx, yes, found the difference after posting here; let me do a PR for moby/moby |
Member
|
opened moby/moby#39308 |
KentaTada
pushed a commit
to KentaTada/runc
that referenced
this pull request
Jun 4, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
KentaTada
pushed a commit
to KentaTada/runc
that referenced
this pull request
Jun 4, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
mauriciovasquezbernal
pushed a commit
to kinvolk/runc
that referenced
this pull request
Jul 23, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
adrianreber
pushed a commit
to adrianreber/runc
that referenced
this pull request
Aug 6, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Dec 31, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
dims
pushed a commit
to dims/libcontainer
that referenced
this pull request
Oct 19, 2024
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
dims
pushed a commit
to dims/libcontainer
that referenced
this pull request
Oct 19, 2024
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All clone flags for namespace should be denied.
Also x/sys should be used instead of syscall.
Signed-off-by: Kenta Tada [email protected]