Import Windows manifest into test build, rather than copying by script#4431
Merged
fuweid merged 1 commit intocontainerd:masterfrom Jul 30, 2020
Merged
Conversation
This will ensure that we can always get the current Windows OS build version, without being put into Windows 8 compatibility mode. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that we can always get the current Windows OS build version, without being put into Windows 8 compatibility mode, and without needing to manually copy files out of hcsshim when manually running the integration testsuite.
Depends on the latest version of vndr (LK4D4/vndr@f12b881) otherwise it will strip rsrc_amd64.syso from the vendor/ tree.
Idea from discussion at #4427 (comment), based on the same pattern in hcsshim itself.