systemd: use LimitNOFILE=infinity instead of hard-coded max value#4475
Merged
fuweid merged 1 commit intocontainerd:masterfrom Aug 17, 2020
Merged
systemd: use LimitNOFILE=infinity instead of hard-coded max value#4475fuweid merged 1 commit intocontainerd:masterfrom
fuweid merged 1 commit intocontainerd:masterfrom
Conversation
According to the systemd documentation, `infinity` can be used for all limits; https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Properties > Resource limits may be specified in two formats: either as single value to set a > specific soft and hard limit to the same value, or as colon-separated pair soft:hard > (...) Use the string infinity to configure no limit on a specific resource. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Build succeeded.
|
Member
|
LGTM 👍 |
Member
Author
|
Given that the purpose of these is to disable accounting, I was also looking at the I'm not sure if that has the same effect though, so if anyone knows someone with more Systemd experience/insight, input welcome! |
1 task
rayburgemeestre
added a commit
to rayburgemeestre/containerd
that referenced
this pull request
Oct 20, 2022
rayburgemeestre
added a commit
to rayburgemeestre/containerd
that referenced
this pull request
Oct 20, 2022
…md_updates" This reverts commit 6c74c39, reversing changes made to 09814d4. Signed-off-by: Ray Burgemeestre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the systemd documentation,
infinitycan be used for all limits;https://www.freedesktop.org/software/systemd/man/systemd.exec.html#Process%20Properties