Freebsd linux containers by gizahNL · Pull Request #5480 · containerd/containerd

gizahNL · 2021-05-11T07:27:06Z

This allows running Linux containers on FreeBSD and modifies the mounts so that they represent the linux emulated filesystems, as per: https://wiki.freebsd.org/LinuxJails
Depends on PR: #5472

k8s-ci-robot · 2021-05-11T07:27:14Z

Hi @gizahNL. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-05-11T07:51:51Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 46s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 34s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 23m 03s (non-voting)

theopenlab-ci · 2021-05-11T09:17:45Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 41s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 33s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 22m 44s (non-voting)

oci/spec_opts.go

theopenlab-ci · 2021-05-11T14:39:48Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 49s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 27s (non-voting)
containerd-integration-test-arm64 : FAILURE in 27m 52s (non-voting)

gizahNL · 2021-05-11T16:07:14Z

Build succeeded.

* [containerd-build-arm64 ](https://logs.openlabtesting.org/logs/80/5480/56574357a0fcac46e3a639c32e401818523b6fc4/check/containerd-build-arm64/8f864eb/) : SUCCESS in 4m 49s (non-voting)

* [containerd-test-arm64 ](https://logs.openlabtesting.org/logs/80/5480/56574357a0fcac46e3a639c32e401818523b6fc4/check/containerd-test-arm64/0ab977d/) : SUCCESS in 5m 27s (non-voting)

* [containerd-integration-test-arm64 ](https://logs.openlabtesting.org/logs/80/5480/56574357a0fcac46e3a639c32e401818523b6fc4/check/containerd-integration-test-arm64/550b8ef/) : FAILURE in 27m 52s (non-voting)

I think the integration test failing is not related to my commits. (I see a timeout)

oci/spec_opts.go

theopenlab-ci · 2021-05-12T14:37:27Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 45s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 32s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 22m 47s (non-voting)

samuelkarp · 2021-05-13T08:11:37Z

oci/spec_opts.go

The other maintainers might feel differently about this so I'm not asking you to make a change yet, but the way I probably would have done this is to define a function like appendOSMounts in each of spec_opts_freebsd.go/spec_opts_linux.go/spec_opts_windows.go with whatever content is appropriate there. The Linux one would likely be empty, but I imagine there could be some use for this on Windows with the LCOW/WCOW work.

In addition to providing a possibly-reusable abstraction for FreeBSD and Windows to achieve similar goals, an advantage is keeping FreeBSD-specific filesystems like "linprocfs" and "linsysfs" out of the common file that is compiled for all operating systems.

The other advantage of this is that, when compiled for FreeBSD, we could also add a WithLinuxEmulationMounts functional option that clients of containerd can use without having to use WithImageConfig/WithImageConfigArgs or even having an image with a declared OS of "linux".

Yes, that seems like a better approach. I'll wait for feedback from the other maintainers.

Does anybody else want to way in on this? I see no issues in rewriting as to Samuel's suggestion.

Samuel's suggestion seems reasonable to me.

Since no one else has said anything: I'd like to see the change that I suggested. 😄

oci/spec_opts.go

platforms/defaults_freebsd.go

samuelkarp · 2021-05-13T08:21:43Z

/ok-to-test

theopenlab-ci · 2021-05-13T11:02:40Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 43s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 38s (non-voting)
containerd-integration-test-arm64 : FAILURE in 21m 18s (non-voting)

alakesh

Wanted to understand why the freebsd defaults for mount points /proc and /dev are missing some of the defaults that we use for linux.

oci/spec_freebsd.go

alakesh · 2021-05-20T01:38:42Z

Thanks for explaining. Looks good to me otherwise.

oci/spec_opts.go

Signed-off-by: Gijs Peskens <[email protected]>

theopenlab-ci · 2021-06-07T19:01:21Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-test-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-integration-test-arm64 : NODE_FAILURE in 0s (non-voting)

Signed-off-by: Gijs Peskens <[email protected]>

Co-authored-by: Samuel Karp <[email protected]> Signed-off-by: Gijs Peskens <[email protected]>

nosuid, noexec options added to /proc and /sys. ro added to /sys Modified code to always add linprocfs & /dev/fd even if not present in existing Mounts slice. Signed-off-by: Gijs Peskens <[email protected]>

theopenlab-ci · 2021-06-07T19:04:24Z

Build succeeded.

containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-test-arm64 : NODE_FAILURE in 0s (non-voting)
containerd-integration-test-arm64 : NODE_FAILURE in 0s (non-voting)

kzys

The change looks good. It would be great if you can tidy up your commit history a bit. For example, the fact you didn't gofmt files in the beginning is not worth to keep.

akhramov · 2021-09-15T10:18:59Z

Hey @gizahNL. I'm sorry to bug you, but are you still working on this?

gizahNL · 2021-09-21T09:53:07Z

Hey @gizahNL. I'm sorry to bug you, but are you still working on this?

Haven't had time recently, I'll try to cleanup and rebase this week :)

Thanks for the reminder!

dmcgowan · 2021-12-09T16:25:26Z

If we want to get this into 1.6 then can we get a rebase on this PR

akhramov · 2022-05-29T13:18:12Z

Superseded by #7000

samuelkarp · 2022-06-09T01:10:27Z

Closing since we've now merged #7000. Thank you for working on this!

k8s-ci-robot added the needs-ok-to-test label May 11, 2021

AkihiroSuda added this to the 1.6 milestone May 11, 2021

AkihiroSuda added the platform/freebsd FreeBSD label May 11, 2021

gizahNL mentioned this pull request May 11, 2021

FreeBSD, linux container, mount lin* filesystems instead of native BSD filesystems #5432

Closed

AkihiroSuda reviewed May 11, 2021

View reviewed changes

oci/spec_opts.go Outdated Show resolved Hide resolved

cpuguy83 requested a review from samuelkarp May 11, 2021 17:11

mxpv reviewed May 11, 2021

View reviewed changes

oci/spec_opts.go Outdated Show resolved Hide resolved

samuelkarp reviewed May 13, 2021

View reviewed changes

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels May 13, 2021

alakesh reviewed May 19, 2021

View reviewed changes

oci/spec_freebsd.go Outdated Show resolved Hide resolved

oci/spec_freebsd.go Outdated Show resolved Hide resolved

oci/spec_freebsd.go Outdated Show resolved Hide resolved

samuelkarp mentioned this pull request May 22, 2021

[question] Linux container support? samuelkarp/runj#4

Open

akhramov reviewed May 22, 2021

View reviewed changes

oci/spec_opts.go Outdated Show resolved Hide resolved

samuelkarp added the kind/feature label May 31, 2021

gizahNL added 4 commits June 7, 2021 20:47

Allow Linux on FreeBSD

19e96b3

Signed-off-by: Gijs Peskens <[email protected]>

Modify FreeBSD mounts when running a Linux image

7c32453

Signed-off-by: Gijs Peskens <[email protected]>

gofmt'ed

6bf12b0

Signed-off-by: Gijs Peskens <[email protected]>

Cleanup left-over debug print

40a7c84

Signed-off-by: Gijs Peskens <[email protected]>

gizahNL force-pushed the freebsd_linux_emulation branch from b1171b2 to 1903d87 Compare June 7, 2021 18:59

Add comments to conditional and function.

073e1f3

Signed-off-by: Gijs Peskens <[email protected]>

gizahNL and others added 2 commits June 7, 2021 21:02

Mirror the DefaultSpec definition.

b4b8eb1

Co-authored-by: Samuel Karp <[email protected]> Signed-off-by: Gijs Peskens <[email protected]>

Add mount options & make sure all fs are present.

13e69ae

nosuid, noexec options added to /proc and /sys. ro added to /sys Modified code to always add linprocfs & /dev/fd even if not present in existing Mounts slice. Signed-off-by: Gijs Peskens <[email protected]>

gizahNL force-pushed the freebsd_linux_emulation branch from 1903d87 to 13e69ae Compare June 7, 2021 19:02

kzys reviewed Jun 10, 2021

View reviewed changes

kzys added the status/needs-update Awaiting contributor update label Jun 15, 2021

dmcgowan modified the milestones: 1.6, 1.7 Jan 12, 2022

akhramov mentioned this pull request May 29, 2022

Linux containers on FreeBSD #7000

Merged

samuelkarp closed this Jun 9, 2022

Conversation

gizahNL commented May 11, 2021

Uh oh!

k8s-ci-robot commented May 11, 2021

Uh oh!

theopenlab-ci bot commented May 11, 2021

Uh oh!

theopenlab-ci bot commented May 11, 2021

Uh oh!

Uh oh!

theopenlab-ci bot commented May 11, 2021

Uh oh!

gizahNL commented May 11, 2021

Uh oh!

Uh oh!

theopenlab-ci bot commented May 12, 2021

Uh oh!

samuelkarp May 13, 2021

Choose a reason for hiding this comment

Uh oh!

gizahNL May 13, 2021

Choose a reason for hiding this comment

Uh oh!

gizahNL Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

emaste Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

samuelkarp Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samuelkarp commented May 13, 2021

Uh oh!

theopenlab-ci bot commented May 13, 2021

Uh oh!

alakesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alakesh commented May 20, 2021

Uh oh!

Uh oh!

theopenlab-ci bot commented Jun 7, 2021

Uh oh!

theopenlab-ci bot commented Jun 7, 2021

Uh oh!

kzys left a comment

Choose a reason for hiding this comment

Uh oh!

akhramov commented Sep 15, 2021

Uh oh!

gizahNL commented Sep 21, 2021

Uh oh!

dmcgowan commented Dec 9, 2021

Uh oh!

akhramov commented May 29, 2022

Uh oh!

samuelkarp commented Jun 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants