Skip to content

fix Implicit memory aliasing in for loop#6331

Merged
estesp merged 1 commit intocontainerd:mainfrom
ningmingxiao:dev2
Feb 22, 2022
Merged

fix Implicit memory aliasing in for loop#6331
estesp merged 1 commit intocontainerd:mainfrom
ningmingxiao:dev2

Conversation

@ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Dec 6, 2021

fix Implicit memory aliasing in for loop

@k8s-ci-robot
Copy link

k8s-ci-robot commented Dec 6, 2021

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 6, 2021

Build succeeded.

thaJeztah
thaJeztah approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 6, 2021

Build succeeded.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Dec 6, 2021

Can we have a unit test?

kzys
kzys approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Regarding unit tests, it might be better to have golangci-lint rules instead.

@kzys
Copy link
Member

kzys commented Jan 31, 2022

/ok-to-test

@kzys
Copy link
Member

kzys commented Feb 22, 2022

@estesp Looks good to merge?

estesp
estesp approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit c79f501 into containerd:main Feb 22, 2022
@estesp
Copy link
Member

estesp commented Feb 22, 2022

Regarding unit tests, it might be better to have golangci-lint rules instead

@kzys Is this something there should an issue opened to track?

@kzys kzys mentioned this pull request Feb 23, 2022
Closed
@kzys
Copy link
Member

kzys commented Feb 23, 2022

@estesp Yes. Cutting #6584 for tracking.

OneDrawer
OneDrawer reviewed Feb 23, 2022
View reviewed changes
Copy link

@OneDrawer OneDrawer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@OneDrawer OneDrawer OneDrawer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ningmingxiao @k8s-ci-robot @AkihiroSuda @kzys @estesp @thaJeztah @OneDrawer @dmcgowan