feat: add volatile option when creating Active snapshot#6528
feat: add volatile option when creating Active snapshot#6528cardyok wants to merge 1 commit intocontainerd:mainfrom
Conversation
|
Hi @cardyok. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cardyok: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cardyok
force-pushed
the
support_volatile_option
branch
6 times, most recently
from
1f03916 to
7de3168
Compare
|
@cardyok: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cardyok
force-pushed
the
support_volatile_option
branch
7 times, most recently
from
7b278ee to
295e6ce
Compare
|
@dmcgowan Do you want to discuss about this PR in the next meeting or the issue itself? |
snapshots/overlay/overlay.go
Outdated
| // the change set between this snapshot and its parent is stored. | ||
| const upperdirKey = "containerd.io/snapshot/overlay.upperdir" | ||
|
|
||
| // volatileOpt is a key of an optional lablel to each snapshot. |
cri callers can add containerd.io/snapshot.volatile annotation to make corresponding snapshot volatile when mounted to rootfs Signed-off-by: cardy.tang <[email protected]>
cardyok
force-pushed
the
support_volatile_option
branch
from
295e6ce to
a692bdb
Compare
|
There seem to be more discussions on #4785 about this feature. |
5 participants
Reference Issue
#6406
What does this implements
cri callers can add
containerd.io/snapshot.volatileannotation to make corresponding snapshot volatile when mounted to rootfs