Remove enumvalue_customname, goproto_enum_prefix and enum_customname#6708
Merged
kzys merged 1 commit intocontainerd:mainfrom Mar 22, 2022
Merged
Remove enumvalue_customname, goproto_enum_prefix and enum_customname#6708kzys merged 1 commit intocontainerd:mainfrom
kzys merged 1 commit intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
This commit removes gogoproto.enumvalue_customname, gogoproto.goproto_enum_prefix and gogoproto.enum_customname. All of them make proto-generated Go code more idiomatic, but we already don't use these enums in our external-surfacing types and they are anyway not supported by Google's official toolchain (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
remove-enum-customization
branch
from
1a8f0f3 to
067611f
Compare
|
Build succeeded.
|
dmcgowan
approved these changes
Mar 21, 2022
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes gogoproto.enumvalue_customname,
gogoproto.goproto_enum_prefix and gogoproto.enum_customname.
All of them make proto-generated Go code more idiomatic, but we already
don't use these enums in our external-surfacing types and they are anyway
not supported by Google's official toolchain (see #6564).
Signed-off-by: Kazuyoshi Kato [email protected]