Rename runtime/v2/task to api/runtime#6827
Merged
fuweid merged 2 commits intocontainerd:mainfrom Apr 20, 2022
Merged
Conversation
Member
|
Can we separate task and sandbox APIs into different packages if they aren't sharing types? It might also be worth exploring joining the root of these packages under |
Move runtime v2 protos to api/runtime package. Signed-off-by: Maksym Pavlenko <[email protected]>
mxpv
changed the title
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 20, 2022
fuweid
approved these changes
Apr 20, 2022
Member
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
LGTM
The package name should be in lowercase. We can update it in followup .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since runtime v2 APIs now include both task and sandbox protos,
this commit renames the Go package to something more generic.move it to
api/runtime.