Remove all gogoproto extensions#6829
Merged
estesp merged 1 commit intocontainerd:mainfrom Apr 20, 2022
Merged
Conversation
kzys
force-pushed
the
always-ptr
branch
2 times, most recently
from
da94604 to
3419df8
Compare
|
Build succeeded.
|
samuelkarp
approved these changes
Apr 20, 2022
dmcgowan
approved these changes
Apr 20, 2022
Member
|
#6827 has been merged. Do we need to rerun the protobuild? |
This commit removes the following gogoproto extensions; - gogoproto.nullable - gogoproto.customename - gogoproto.unmarshaller_all - gogoproto.stringer_all - gogoproto.sizer_all - gogoproto.marshaler_all - gogoproto.goproto_unregonized_all - gogoproto.goproto_stringer_all - gogoproto.goproto_getters_all None of them are supported by Google's toolchain (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
|
Build succeeded.
|
fuweid
approved these changes
Apr 20, 2022
Member
|
The change needs to notify the user who using proxy snapshot about the API change. I added the label |
This was referenced Feb 25, 2023
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the following gogoproto extensions;
None of them are supported by Google's toolchain (see #6564).
Signed-off-by: Kazuyoshi Kato [email protected]