Fork CRI server for Sandbox API integration work#7164
Merged
fuweid merged 4 commits intocontainerd:mainfrom Jul 15, 2022
Merged
Fork CRI server for Sandbox API integration work#7164fuweid merged 4 commits intocontainerd:mainfrom
fuweid merged 4 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
panic: duplicate metrics collector registration attempted Signed-off-by: Maksym Pavlenko <[email protected]>
![github-advanced-security[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else if isLocalHost(host) && u.Scheme == "http" { | ||
| // Skipping TLS verification for localhost | ||
| transport.TLSClientConfig = &tls.Config{ | ||
| InsecureSkipVerify: true, |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check
Member
Author
|
/test pull-containerd-node-e2e |
mikebrow
reviewed
Jul 14, 2022
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
a couple comments about the new env variable..
Signed-off-by: Maksym Pavlenko <[email protected]>
mikebrow
approved these changes
Jul 14, 2022
Member
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
LGTM
per slack discussion will remove support for the environment setup as soon as we have some config toml to replace it.. (before r.next)
fuweid
approved these changes
Jul 15, 2022
Member
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
LGTM
Basically test it in local and it works well. Agree to use config to enable sbserver instead of env.
And we also update some integration cases in follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forks
cri/server->cri/sbserverpackage to unblock Sandbox CRI integration. This will allow us to iterate faster and don't worry about affecting existing CRI users.Because we haven't figured out how exactly we'll be switching between CRI implementations (either an option in the CRI config or runtime or something else), I've added
ENABLE_CRI_SANDBOXESenv variable, which makes it really easy to enable integration tests.