Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
fuweid
reviewed
Aug 5, 2022
Signed-off-by: Maksym Pavlenko <[email protected]>
mxpv
force-pushed
the
go
branch
4 times, most recently
from
e80e4a1 to
05b0693
Compare
mxpv
force-pushed
the
go
branch
4 times, most recently
from
85f5043 to
55e402f
Compare
Signed-off-by: Maksym Pavlenko <[email protected]>
Member
Author
|
/test pull-containerd-sandboxed-node-e2e |
fuweid
reviewed
Aug 6, 2022
Signed-off-by: Maksym Pavlenko <[email protected]>
dmcgowan
approved these changes
Aug 9, 2022
Member
|
I marked this as cherry-pick for 1.6 as well since we will be supporting the 1.6 branch longer than go 1.18 will be supported. We don't necessarily need to cherry-pick right away though or use the same commits. |
fuweid
approved these changes
Aug 10, 2022
| Addr: s.config.Addr, | ||
| Handler: s.handler, | ||
| TLSConfig: s.config.TLSConfig, | ||
| ReadHeaderTimeout: 3 * time.Second, // Fix linter G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server |
Member
There was a problem hiding this comment.
No sure 3 second is good enough. Just in case, the 10 Minutes maybe better than 3 second because there is no limit at the beginning.
It's not block issue. But if we change it to low tolerance value, we should mark it in change log.
Cc @mikebrow
Member
There was a problem hiding this comment.
yeah this one is very likely to cause node failures..
Member
There was a problem hiding this comment.
I agree maybe 10 or 15min.. maybe 30?
dcantah
approved these changes
Aug 10, 2022
fuweid
added a commit
to fuweid/containerd
that referenced
this pull request
Aug 13, 2022
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
fuweid
added a commit
to fuweid/containerd
that referenced
this pull request
Aug 17, 2022
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
fuweid
added a commit
to fuweid/containerd
that referenced
this pull request
Aug 17, 2022
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
estesp
added a commit
that referenced
this pull request
Aug 18, 2022
Follow up #7254 (Switch to Go 1.19)
Closed
vvejell1
pushed a commit
to vvejell1/containerd
that referenced
this pull request
Nov 4, 2022
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
thaJeztah
pushed a commit
to thaJeztah/containerd
that referenced
this pull request
Mar 7, 2023
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit 460b053) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
cherry-picked/1.6.x
jsturtevant
pushed a commit
to jsturtevant/containerd
that referenced
this pull request
Sep 21, 2023
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
kiashok
pushed a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maksym Pavlenko [email protected]