Follow up #7254 (Switch to Go 1.19)#7286
Merged
estesp merged 2 commits intocontainerd:mainfrom Aug 18, 2022
Merged
Conversation
mxpv
approved these changes
Aug 13, 2022
Member
|
Was hoping it wasn't something in my change, but looks like gopkg is out to lunch indeed |
dcantah
approved these changes
Aug 13, 2022
Contributor
|
Member
|
@fuweid Can rebase now that the CI should be back in order |
Member
Author
For sure. Updated |
It is follow-up of containerd#7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what containerd#7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <[email protected]>
Align with https://github.com/containerd/project/blob/main/script/validate/template/go.txt. Signed-off-by: Wei Fu <[email protected]>
Member
Author
Hmm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is follow-up of #7254. This commit will increase ReadHeaderTimeout
from 3s to 30m, which prevent from unexpected timeout when the node is
running with high-load. 30 Minutes is longer enough to get close to
before what #7254 changes.
And ideally, we should allow user to configure the streaming server if
the users want this feature.
Align with https://github.com/containerd/project/blob/main/script/validate/template/go.txt.
cc @mxpv and @mikebrow