feature: get cpu architecture info#7295
Conversation
|
Hi @lengrongfu. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lengrongfu
force-pushed
the
feat_cpuarchitecture_info
branch
from
b515dfa to
1958c8a
Compare
lengrongfu
force-pushed
the
feat_cpuarchitecture_info
branch
2 times, most recently
from
45e0a8e to
a7e4e23
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Left some thoughts/questions
Signed-off-by: lengrongfu <[email protected]>
lengrongfu
force-pushed
the
feat_cpuarchitecture_info
branch
from
a7e4e23 to
a81c041
Compare
go.mod
Outdated
| require ( | ||
| github.com/AdaLogics/go-fuzz-headers v0.0.0-20220706123152-fef3fe1bab07 | ||
| github.com/Microsoft/go-winio v0.5.2 | ||
| github.com/agiledragon/gomonkey/v2 v2.8.0 |
There was a problem hiding this comment.
I don’t think we want to introduce this dependency.
Probably hard to debug potential issues
There was a problem hiding this comment.
This is just for auxiliary unit testing, without this, I can't think of any other way to mock some functions inside.
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please see my comments above
lengrongfu
force-pushed
the
feat_cpuarchitecture_info
branch
2 times, most recently
from
f567be9 to
9914bfe
Compare
Signed-off-by: lengrongfu <[email protected]> Signed-off-by: lengrongfu <[email protected]>
lengrongfu
force-pushed
the
feat_cpuarchitecture_info
branch
from
9914bfe to
687a9b3
Compare
5 participants
Signed-off-by: lengrongfu [email protected]
ref: #4109