Make checkContainerTimestamps less strict on Windows#7350
Merged
estesp merged 1 commit intocontainerd:mainfrom Sep 1, 2022
Merged
Make checkContainerTimestamps less strict on Windows#7350estesp merged 1 commit intocontainerd:mainfrom
estesp merged 1 commit intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
This assertion is flaky on Windows. Because of Go, Windows' time.Now resolution is lower than Linux. Signed-off-by: Kazuyoshi Kato <[email protected]>
estesp
approved these changes
Sep 1, 2022
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
Haven't seen this flake as often, but it definitely comes around on a regular basis and so this makes sense from a CI stability perspective.
This was referenced Jul 14, 2023
thaJeztah
added
the
cherry-picked/1.6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assertion is flaky on Windows.
Because of Go, Windows' time.Now resolution is lower than Linux.