Don't unmount on Darwin when deleting bundle#7534
Merged
estesp merged 1 commit intocontainerd:mainfrom Oct 17, 2022
Merged
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
AkihiroSuda
reviewed
Oct 15, 2022
| if runtime.GOOS != "darwin" { | ||
| if err := mount.UnmountAll(rootfs, 0); err != nil { | ||
| return fmt.Errorf("unmount rootfs %s: %w", rootfs, err) | ||
| } |
Member
There was a problem hiding this comment.
Is there any possibility that a future version of Darwin may support nullfs (bind-mount) ?
If yes, the runtime has still try to unmount the rootfs (and ignore the error)
Member
Author
There was a problem hiding this comment.
Support of mounts on MacOS is fairly limited today and I'm not aware of any plans to support new features. I'm happy to change this once mounts are more usable on this platform.
Contributor
There was a problem hiding this comment.
Is there any possibility that a future version of Darwin may support nullfs (bind-mount) ?
See #8789 (and yes, it reverts this change).
samuelkarp
approved these changes
Oct 16, 2022
AkihiroSuda
approved these changes
Oct 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
Bundle.Deleteon Darwin, it attempts to unmount rootfs, which is not supported. This PR skips unmount for this platform, just deleting the directory would be sufficient.Signed-off-by: Maksym Pavlenko [email protected]