Merged
Conversation
Member
|
We should change it in all 10 files that we usually do when we update versions (see #7474) |
Signed-off-by: Brian Goff <[email protected]>
estesp
approved these changes
Nov 2, 2022
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM ..looks like somebody's IDE/editor wanted to fix up some whitespace and quoting along the way 🤓
Member
Author
|
lol, indeed. |
dmcgowan
approved these changes
Nov 2, 2022
kzys
approved these changes
Nov 2, 2022
This was referenced Nov 5, 2022
Member
|
Opened updates to 1.18.8 for the release branches as well; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a runtime bug found in #7513