Skip to content

fix: 'go routine' should be 'goroutine'#8051

Merged
dmcgowan merged 1 commit intocontainerd:mainfrom
yulng:goroutine
Feb 15, 2023
Merged

fix: 'go routine' should be 'goroutine'#8051
dmcgowan merged 1 commit intocontainerd:mainfrom
yulng:goroutine

Conversation

@yulng
Copy link
Contributor

@yulng yulng commented Feb 5, 2023

Signed-off-by: yulng [email protected]

Usually, go routine is represented by goroutine

Thanks

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 5, 2023

Hi @yulng. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcantah
Copy link
Member

dcantah commented Feb 6, 2023

Looks like the pr description has a DCO but the commit doesn't. Please git commit --amend -s

dcantah
dcantah approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after DCO

@yulng
Copy link
Contributor Author

yulng commented Feb 8, 2023

Looks like the pr description has a DCO but the commit doesn't. Please git commit --amend -s

It has been changed

estesp
estesp approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 179f00c into containerd:main Feb 15, 2023
kiashok added a commit to kiashok/containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 7712980: Update fork-external/main with upstream main
8cdc0dc 
Update fork-external/main with upstream main at commit [081d818](containerd@081d818)

Marged upstream container/main into fork-external/main

Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yulng @k8s-ci-robot @dcantah @dmcgowan @estesp