docs: Show how to select GRPC for shims#8134
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Feb 25, 2023
Merged
Conversation
This updates the runtime/v2 README to state the experimental GRPC support for shims and how to choose the protocol. Signed-off-by: Danny Canter <[email protected]>
dcantah
force-pushed
the
docs-rtime-grpc-shims
branch
from
6dd7822 to
ea83632
Compare
AkihiroSuda
approved these changes
Feb 19, 2023
samuelkarp
reviewed
Feb 19, 2023
| #### ttrpc | ||
|
|
||
| [ttrpc](https://github.com/containerd/ttrpc) is the only currently supported protocol for shims. | ||
| [ttrpc](https://github.com/containerd/ttrpc) is one of the supported protocols for shims. |
Member
There was a problem hiding this comment.
nit: the phrasing here is a bit awkward
Suggested change
| [ttrpc](https://github.com/containerd/ttrpc) is one of the supported protocols for shims. | |
| [ttrpc](https://github.com/containerd/ttrpc) is the recommended protocols for shims. |
Member
Author
There was a problem hiding this comment.
@samuelkarp It seemed redundant to state it's recommended as there's a blurb at the bottom was my thought process 🤷♂️ Would you wanna change to this and get rid of the
It is recommended to use ttrpc in your shim but grpc support is currently an experimental feature.
Or I guess the bottom could be "As stated, it is recommended to use ttrpc in your shim but grpc support is currently an experimental feature."
fuweid
approved these changes
Feb 21, 2023
dmcgowan
approved these changes
Feb 25, 2023
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
Update fork-external/main with upstream main at commit [081d818](containerd@081d818) Marged upstream container/main into fork-external/main Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the runtime/v2 README to state the experimental GRPC support for shims and how to choose the protocol.