Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Member
Author
|
/test all |
Member
|
needs rebase |
Signed-off-by: Jian Zeng <[email protected]>
Signed-off-by: Jian Zeng <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
transfer-export-image
branch
from
eee7692 to
3f33fcb
Compare
mxpv
approved these changes
Mar 2, 2023
estesp
approved these changes
Mar 2, 2023
mikebrow
approved these changes
Mar 2, 2023
cmd/ctr/commands/images/export.go
Outdated
| return err | ||
| } | ||
|
|
||
| return nil |
Member
There was a problem hiding this comment.
nit ... without the progress update here.. return err would be the same as !=nil return.. then return nil here
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
transfer-export-image
branch
from
3f33fcb to
13bf556
Compare
kiashok
added a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
Update fork-external/main with upstream main at commit [081d818](containerd@081d818) Marged upstream container/main into fork-external/main Related work items: containerd#7864, containerd#7954, containerd#8041, containerd#8044, containerd#8051, containerd#8062, containerd#8096, containerd#8103, containerd#8109, containerd#8110, containerd#8113, containerd#8114, containerd#8119, containerd#8120, containerd#8128, containerd#8130, containerd#8134, containerd#8140, containerd#8142, containerd#8143, containerd#8152, containerd#8154, containerd#8162, containerd#8164, containerd#8165, containerd#8172, containerd#8173, containerd#8177, containerd#8178, containerd#8181, containerd#8183, containerd#8187, containerd#8188, containerd#8189, containerd#8190, containerd#8191, containerd#8192, containerd#8193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry of #7916
Ref #7592
Summary
Implement exporting image using the new
TransferAPI.Implementation Details
Invoke the
TransferAPI with a dummyimage.Storeas source andarchive.ImageExportStreamas destination.The reason why a dummy
image.Storeis chosen as source here is I learnt that the images to export are actually read on the containerd side, notctrand we need to distinguish the export scenario from the others, so I choose to send a dummyimage.Storeto tell the local transfer service about that.In addition, I have added some options to the
archive.ImageExportStreamto gain the same ability as "non-local" export. These options are hold in a config struct, does not follow the functional options pattern, b/c I think this would save me some typings. This might be opinionated, I could switch to functional options if that's necessary.