RELEASES.md: describe the deprecated config properties#8241
RELEASES.md: describe the deprecated config properties#8241mxpv merged 1 commit intocontainerd:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
AkihiroSuda
force-pushed
the
deprecation-20230309
branch
from
ff2238c to
2e2c848
Compare
| // Configs are configs for each registry. | ||
| // The key is the domain name or IP of the registry. | ||
| // This option will be fully deprecated for ConfigPath in the future. | ||
| // DEPRECATED: Use ConfigPath instead. |
There was a problem hiding this comment.
(This has been already deprecated since v1.5)
containerd/releases/v1.5.0.toml
Line 133 in 1f236dc
| // today, who don't have a cni daemonset in production. NetworkPluginConfTemplate is | ||
| // a temporary backward-compatible solution for them. | ||
| // TODO(random-liu): Deprecate this option when kubenet is deprecated. | ||
| // DEPRECATED: use CNI configs |
There was a problem hiding this comment.
Substantially we have been deprecating this for years, but looks like we have forgotten to formally deprecate it
There was a problem hiding this comment.
Commented on #8596. It's unfortunate this was ostensibly deprecated for so long without any notice, I don't think a reasonable replacement is readily available yet. This allowed for very simple generic networking using the Kubernetes built in node pod CIDR IPAM, avoiding the need to fetch the node object through some external process (which has scalability, auth, complexity issues).
There was a problem hiding this comment.
This TODO is from a time where this field was going to be deprecated and made sense at that point in time kubernetes/kubernetes#57130
However, the time evolved and showed to be useful and there are several projects dependent on it , as a proof you can see that the kubernetes field got added new features instead of being deprecated as you can see in this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2593-multiple-cluster-cidrs
So, it seems that happened here is that we forget to tell containerd how useful is this field and this TODO should have been removed
There was a problem hiding this comment.
Sure, let's de-deprecate this
AkihiroSuda
force-pushed
the
deprecation-20230309
branch
3 times, most recently
from
17f1685 to
de3f80b
Compare
RELEASES.md
Outdated
| |`[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.*]` | `runtime_engine` | containerd v1.3 | containerd v2.0 | Use runtime v2 | | ||
| |`[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.*]` | `runtime_root` | containerd v1.3 | containerd v2.0 | Use `options.Root` | | ||
| |`[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.*.options]` | `CriuPath` | containerd v1.7 | containerd v2.0 | Set `$PATH` to the `criu` binary | | ||
| |`[plugins."io.containerd.grpc.v1.cri".registry]` | `auths` | containerd v1.3 | containerd v2.0 | Use [`config_path`](./docs/hosts.md) | |
There was a problem hiding this comment.
config_path does not have support for authentication and there is no plan to have it supported in this way. Recommendation would be use pull secrets or could link to an in progress issue for 2.0.
AkihiroSuda
force-pushed
the
deprecation-20230309
branch
from
de3f80b to
3d48d9e
Compare
These deprecations were mentioned in `pkg/cri/config/config.go` but not mentioned in `RELEASES.md`. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
deprecation-20230309
branch
from
3d48d9e to
625217d
Compare
6 participants
These deprecations were mentioned in
pkg/cri/config/config.gobut not mentioned inRELEASES.md.