Skip to content

notify readiness when registered plugins are ready#8576

Merged
samuelkarp merged 1 commit intocontainerd:mainfrom
henry118:ready
May 26, 2023
Merged

notify readiness when registered plugins are ready#8576
samuelkarp merged 1 commit intocontainerd:mainfrom
henry118:ready

Conversation

@henry118
Copy link
Member

@henry118 henry118 commented May 26, 2023

Fix: #8468

Added RegisterReadiness func to InitContext to allow plugins to register themselves as required plugins which will be waited for the readiness before systemd notification is sent. This PR only registers CRI plugin to address #8468.

@k8s-ci-robot
Copy link

k8s-ci-robot commented May 26, 2023

Hi @henry118. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samuelkarp
Copy link
Member

samuelkarp commented May 26, 2023

/ok-to-test

estesp
estesp approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this seems like a reasonable way to solve the "is it really ready" issue with kubelet+CRI

samuelkarp
samuelkarp approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me.

@samuelkarp samuelkarp merged commit d0dba8e into containerd:main May 26, 2023
@henry118 henry118 deleted the ready branch May 26, 2023 22:04
@henry118
Copy link
Member Author

henry118 commented May 26, 2023

Thanks @samuelkarp and @estesp for the review.

Can we backport this patch to 1.6 and 1.7? If so I'm happy to open the PRs too.

@samuelkarp samuelkarp added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels May 26, 2023
@samuelkarp
Copy link
Member

samuelkarp commented May 26, 2023

Yes, I'd like to see this backported to both 1.6 and 1.7.

@dims
Copy link
Member

dims commented May 26, 2023

+100 to backport

This was referenced May 27, 2023
Merged
Merged
@thaJeztah thaJeztah added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

containerd systemd unit started before containerd is fully ready

6 participants

@henry118 @k8s-ci-robot @samuelkarp @dims @estesp @thaJeztah