[release/1.7] Backport CRI sandbox server stats changes#8604
Merged
mxpv merged 3 commits intocontainerd:release/1.7from May 31, 2023
Merged
[release/1.7] Backport CRI sandbox server stats changes#8604mxpv merged 3 commits intocontainerd:release/1.7from
mxpv merged 3 commits intocontainerd:release/1.7from
Conversation
Member
dcantah
commented
May 30, 2023
- d08b2a0
- 8d7c340
- 7851b0a
Signed-off-by: Maksym Pavlenko <[email protected]> (cherry picked from commit 464a497) Signed-off-by: Danny Canter <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]> (cherry picked from commit 79cb4b0) Signed-off-by: Danny Canter <[email protected]>
To further some ongoing work in containerd to make as much code as possible able to be used on any platform (to handle runtimes that can virtualize/emulate a variety of different OSes), this change makes stats able to be handled on any of the supported stat types (just linux and windows). To accomplish this, we use the platform the sandbox returns from its `Platform` rpc to decide what format the containers in a given sandbox are returning metrics in, then we can typecast/marshal accordingly. Signed-off-by: Danny Canter <[email protected]> (cherry picked from commit 7274e33)
dmcgowan
approved these changes
May 30, 2023
Member
|
Related? |
Member
Author
Yea, this wouldn't fail without these changes, but it's basically saying that the pod for this containers been deleted/removed already, so maybe these changes have unearthed a bug that was dormant.. |
mxpv
approved these changes
May 31, 2023
This was referenced Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.