Revert "Add support for bind-mounts on Darwin (a.k.a. "make native snapshotter work")" (#8789)#8838
Merged
AkihiroSuda merged 2 commits intocontainerd:mainfrom Jul 18, 2023
Merged
Conversation
This reverts commit 6c9c711. Signed-off-by: Akihiro Suda <[email protected]>
This reverts commit 2799b28. Signed-off-by: Akihiro Suda <[email protected]>
kzys
approved these changes
Jul 18, 2023
mxpv
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert:
The feature can be probably added again with a proper abstract interface that does not introduce a dependency on an external binary by default.