Skip to content

Migrate to community bucket for node e2e tests#8862

Merged
fuweid merged 1 commit intocontainerd:mainfrom
borg-land:change-buckets
Jul 26, 2023
Merged

Migrate to community bucket for node e2e tests#8862
fuweid merged 1 commit intocontainerd:mainfrom
borg-land:change-buckets

Conversation

@upodroid
Copy link
Contributor

@upodroid upodroid commented Jul 24, 2023

@k8s-ci-robot k8s-ci-robot requested review from dims and mikebrow July 24, 2023 19:18
@k8s-ci-robot
Copy link

k8s-ci-robot commented Jul 24, 2023

@upodroid: GitHub didn't allow me to request PR reviews from the following users: akhilerm.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Part of:

/cc @dims @mikebrow @akhilerm

btw, I need someone to run /ok-to-test on this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Jul 24, 2023

Hi @upodroid. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid upodroid mentioned this pull request Jul 24, 2023
Merged
@mikebrow
Copy link
Member

mikebrow commented Jul 24, 2023

/ok-to-test

mikebrow
mikebrow approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green.. and signed.. we can always revert if need... will want to cherry this when done..

@upodroid note the deploy DIR.. pls confirm this does not need to be in bucket/containerd

@upodroid
Copy link
Contributor Author

upodroid commented Jul 24, 2023

I'll fix the DCO.

DEPLOY_DIR defaults to gs://BUCKET_NAME/containerd/COMMIT_SHA which is fine.

@upodroid
Copy link
Contributor Author

upodroid commented Jul 24, 2023

btw, we need to backport this PR to 1.6 and 1.7 release branches

@upodroid
Copy link
Contributor Author

upodroid commented Jul 24, 2023

/cherry-pick release-1.6
/cherry-pick release-1.7

dims
dims approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@upodroid
Copy link
Contributor Author

upodroid commented Jul 24, 2023

/test pull-containerd-node-e2e

k/test-infra should be referencing the correct bucket now

@mikebrow mikebrow added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Jul 24, 2023
@mikebrow
Copy link
Member

mikebrow commented Jul 24, 2023

Please sign with your real name.. https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work Thanks!

akhilerm
akhilerm reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@akhilerm akhilerm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same bucket name is also used in the containerd installation script. We need to change that also to point to the new bucket. https://github.com/containerd/containerd/blob/main/contrib/gce/configure.sh#L124-L128

@upodroid
Copy link
Contributor Author

upodroid commented Jul 25, 2023

Done and I fixed the DCO.

@upodroid upodroid mentioned this pull request Jul 25, 2023
Closed
akhilerm
akhilerm approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fuweid
fuweid approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 8348a8c into containerd:main Jul 26, 2023
@akhilerm
Copy link
Member

akhilerm commented Jul 26, 2023

I will raise the cherry picks to 1.6 and 1.7

@akhilerm akhilerm mentioned this pull request Jul 26, 2023
Merged
@akhilerm akhilerm mentioned this pull request Jul 26, 2023
Merged
@samuelkarp samuelkarp added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Dec 1, 2023
Thompson1985

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@akhilerm akhilerm akhilerm approved these changes

@mikebrow mikebrow mikebrow approved these changes

@fuweid fuweid fuweid approved these changes

+1 more reviewer

@Thompson1985 Thompson1985 Thompson1985 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@upodroid @k8s-ci-robot @mikebrow @akhilerm @dims @fuweid @Thompson1985 @samuelkarp