Makefile: allow overriding GO_BUILD_FLAGS via environment#8934
Makefile: allow overriding GO_BUILD_FLAGS via environment#8934samuelkarp merged 1 commit intocontainerd:mainfrom
Conversation
|
Hi @metux. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
would you please unify your recent open pull requests into one? I'm not sure that it's good to have too much flexible options... |
metux
force-pushed
the
submit/go_build_flags
branch
3 times, most recently
from
7b001e2 to
05b094d
Compare
Squash it w/ #8936 ? |
|
looks like windows integration test has some problem unrelated to this PR |
metux
force-pushed
the
submit/go_build_flags
branch
5 times, most recently
from
3416f30 to
e73ae5f
Compare
Allow overriding GO_BUILD_FLAGS via environment, do distros can easily inject additionally required build flags (eg. -buildvcs=false). Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux
force-pushed
the
submit/go_build_flags
branch
from
e73ae5f to
f9c35fe
Compare
|
LGTM |
…h upstream containerd/main update fork-external/main branch to upstream containerd/main at commit f90f80d Related work items: containerd#8736, containerd#8861, containerd#8924, containerd#8934, containerd#9027, containerd#9076, containerd#9104, containerd#9118, containerd#9141, containerd#9155, containerd#9177, containerd#9183, containerd#9184, containerd#9186, containerd#9187, containerd#9191, containerd#9200, containerd#9205, containerd#9211, containerd#9214, containerd#9215, containerd#9221, containerd#9223, containerd#9228, containerd#9231, containerd#9234, containerd#9242, containerd#9246, containerd#9247, containerd#9251, containerd#9253, containerd#9254, containerd#9255, containerd#9268
6 participants
Allow overriding GO_BUILD_FLAGS via environment, do distros can easily inject additionally required build flags (eg. -buildvcs=false).