alias log package to github.com/containerd/log v0.1.0, and (soft)deprecate#9093
Merged
dmcgowan merged 2 commits intocontainerd:mainfrom Sep 20, 2023
Merged
alias log package to github.com/containerd/log v0.1.0, and (soft)deprecate#9093dmcgowan merged 2 commits intocontainerd:mainfrom
dmcgowan merged 2 commits intocontainerd:mainfrom
Conversation
thaJeztah
force-pushed
the
swap_log_pkg_alias
branch
from
3aa958f to
7763ed9
Compare
This was referenced Sep 13, 2023
AkihiroSuda
approved these changes
Sep 16, 2023
This was referenced Sep 17, 2023
Member
|
Needs rebase |
thaJeztah
force-pushed
the
swap_log_pkg_alias
branch
from
7763ed9 to
7a94603
Compare
This "soft" deprecates the package, but keeps the local uses of the package, which can make backporting this to release-branches easier (we can still move all uses in those branches as well though). Signed-off-by: Sebastiaan van Stijn <[email protected]>
Deprecate the pacakge, but suppress linting errors for now. This is to allow backporting these changes to release branches, which may still need to transition. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
swap_log_pkg_alias
branch
from
7a94603 to
03b9ce5
Compare
AkihiroSuda
approved these changes
Sep 19, 2023
Member
Author
|
/retest-required |
dmcgowan
requested changes
Sep 20, 2023
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
I think we should just close this one, we don't need to soft deprecate this in main. This change is necessary for 1.7 and 1.6 only, which are already opened up.
dmcgowan
approved these changes
Sep 20, 2023
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
I'll rebase off this one so these commits and can cherry-pick these commits to 1.6/1.7
This was referenced May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of the changes in #9086, to make backporting to release branches easier.
alias log package to github.com/containerd/log v0.1.0
This "soft" deprecates the package, but keeps the local uses of the package,
which can make backporting this to release-branches easier (we can
still move all uses in those branches as well though).
deprecate logs package, but disable linter (for transitioning)
Deprecate the pacakge, but suppress linting errors for now. This is to allow
backporting these changes to release branches, which may still need to transition.