[release/1.7] Handle unexpected shim kill events#9132
Merged
fuweid merged 1 commit intocontainerd:release/1.7from Sep 30, 2023
Merged
[release/1.7] Handle unexpected shim kill events#9132fuweid merged 1 commit intocontainerd:release/1.7from
fuweid merged 1 commit intocontainerd:release/1.7from
Conversation
dmcgowan
approved these changes
Sep 22, 2023
mxpv
approved these changes
Sep 23, 2023
Member
|
/retest |
When a shim process is unexpectedly killed in a way that was not initiated through containerd - containerd reports the pod as not ready but the containers as running. This results in kubelet repeatedly sending container kill requests that fail since containerd cannot connect to the shim. Changes: - In the container exit handler, treat `err: Unavailable` as if the container has already exited out - When attempting to get a connection to the shim, if the controller isn't available assume that the shim has been killed (needs to be done since we have a separate exit handler that cleans up the reference to the shim controller - before kubelet has the chance to call StopPodSandbox) Signed-off-by: Aditya Ramani <[email protected]> (cherry picked from commit 729c97c) Signed-off-by: Danny Canter <[email protected]>
dcantah
force-pushed
the
shim-kill-1.7
branch
from
ef82d86 to
3d27bc7
Compare
Member
Author
|
Rebased after the Windows mingw fixes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shim process is unexpectedly killed in a way that was not initiated through containerd - containerd reports the pod as not ready but the containers as running. This results in kubelet repeatedly sending container kill requests that fail since containerd cannot connect to the shim.
Changes:
err: Unavailableas if the container has already exited out(cherry picked from commit 729c97c)