[WIP] Preunpack right after downloading#9138
Conversation
|
Hi @ike-ma. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
elfinhe
left a comment
elfinhe
left a comment
There was a problem hiding this comment.
Maybe need to
- Add more context for where the preunpacked layers are stored.
- On which filesystem it will work.
- Add some initial results for observed improvements.
|
/reviewer @dmcgowan |
|
Please sign your commit. Even for draft PRs we'd like to get some signal from CI and it won't pass the Project Checks step without a sign-off line. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed. |
|
Hello there ! Nice PR
Is this blocked by something else ? |
Happy if someone can take over the work here. I did create the hacky prototype, but now the team didn't get enough resource to prioritize the work. But I can help communicate through containerd maintainers to figure out the next steps. |
Oh, yes please ! 😄 happy to pull/help here ! |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
7 participants
This is a WIP PR to get feedback from community
Related issue: #8881
Hight level idea of pre-unpacking is to decompress the fetched layer right away in parallel in goroutine (as oppose to decompress in serial later on)
pkg/unpacker.go: Generate the preunpackeddiff.Apply->diff.apply_linux.apply->archive.tar.Apply()->archive.tar.applyNative()archive/tar_opts.go: Add UsePreunpackedLayer related config/var/lib/containerd/tmpoverlayfs/blobs/DIGEST.unpack.unpackfile contains the following