Skip to content

Bump up golangci-lint to v1.54.2#9186

Merged
estesp merged 2 commits intocontainerd:mainfrom
ktock:golangci-lint-v1.54.2
Oct 3, 2023
Merged

Bump up golangci-lint to v1.54.2#9186
estesp merged 2 commits intocontainerd:mainfrom
ktock:golangci-lint-v1.54.2

Conversation

@ktock
Copy link
Member

@ktock ktock commented Oct 3, 2023

golangci-lint v1.54.2: https://github.com/golangci/golangci-lint/releases/tag/v1.54.2

This PR also fixes the following linter issues:

content/helpers_test.go:148:5: G601: Implicit memory aliasing in for loop. (gosec)
				&testcase.writer,
				^
metrics/cgroups/v1/oom.go:101:25: G601: Implicit memory aliasing in for loop. (gosec)
		c := atomic.LoadInt64(&t.count)
		                      ^
tracing/plugin/otlp_test.go:77:33: G601: Implicit memory aliasing in for loop. (gosec)
			exp, err := newExporter(ctx, &testcase.input)
			                             ^
pkg/cri/sbserver/images/image_status_test.go:32:2: G101: Potential hardcoded credentials (gosec)
	testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4"
	^
pkg/cri/sbserver/images/service_test.go:38:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
pkg/cri/sbserver/podsandbox/controller_test.go:37:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
metadata/containers_test.go:650:37: G601: Implicit memory aliasing in for loop. (gosec)
			checkContainersEqual(t, &result, &testcase.original, "unexpected result on container update")
			                                 ^
metadata/containers_test.go:666:37: G601: Implicit memory aliasing in for loop. (gosec)
			checkContainersEqual(t, &result, &testcase.expected, "updated failed to get expected result")
			                                 ^
metadata/containers_test.go:673:37: G601: Implicit memory aliasing in for loop. (gosec)
			checkContainersEqual(t, &result, &testcase.expected, "get after failed to get expected result")
			                                 ^
metadata/images_test.go:515:34: G601: Implicit memory aliasing in for loop. (gosec)
			checkImagesEqual(t, &created, &testcase.original, "unexpected image on creation")
			                              ^
metadata/images_test.go:532:34: G601: Implicit memory aliasing in for loop. (gosec)
			checkImagesEqual(t, &updated, &testcase.expected, "updated failed to get expected result")
			                              ^
metadata/images_test.go:540:33: G601: Implicit memory aliasing in for loop. (gosec)
			checkImagesEqual(t, &result, &testcase.expected, "get after failed to get expected result")
			                             ^
pkg/cri/sbserver/test_config.go:27:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
pkg/cri/server/test_config.go:27:2: G101: Potential hardcoded credentials (gosec)
	testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
	^
pkg/cri/server/image_status_test.go:32:2: G101: Potential hardcoded credentials (gosec)
	testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4"
	^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants