integration: init release upgrade testing#9262
Conversation
|
Skipping CI for Draft Pull Request. |
fuweid
force-pushed
the
init-upgrade-test
branch
6 times, most recently
from
171d0e8 to
6c827c4
Compare
fuweid
requested review from
AkihiroSuda,
dmcgowan and
mxpv
and removed request for
mxpv
fuweid
force-pushed
the
init-upgrade-test
branch
from
6c827c4 to
72cc895
Compare
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
This is pretty neat! A few comments, but I'm generally happy with it.
| require.NoError(t, previousProc.kill(syscall.SIGTERM)) | ||
| require.NoError(t, previousProc.wait()) |
There was a problem hiding this comment.
Maybe a timeout here? Or (see other comment about pdeathsig) have the parent goroutine in a locked OS thread exit, causing SIGKILL to be sent?
There was a problem hiding this comment.
I changed the wait() to wait(timeout time.Duration). And also add new goroutine to wait for containerd's exit event with locked OS thread. PTAL
|
|
||
| // downloadPreviousReleaseBinary downloads the latest version of previous release | ||
| // into the target dir. | ||
| func downloadPreviousReleaseBinary(t *testing.T, targetDir string) { |
There was a problem hiding this comment.
We may eventually want a way to supply a local containerd archive instead of downloading one, especially if we want this test to be usable for distros who build their own containerd. But I don't think we need to do that now.
The TestUpgrade downloads the latest of previous release's binary and use them to setup pods and then use current release to recover the existing pods. Signed-off-by: Wei Fu <[email protected]>
fuweid
force-pushed
the
init-upgrade-test
branch
from
72cc895 to
2fab240
Compare
|
@samuelkarp Updated with your suggestion. PTAL. Thanks! The test result is here. |
| // upgradeVerifyCaseFunc is used to verify the behavior after upgrade. | ||
| type upgradeVerifyCaseFunc func(t *testing.T, criRuntimeService cri.RuntimeService) | ||
|
|
||
| // TODO: Support Windows |
There was a problem hiding this comment.
oops. Just saw this comment. I will add the link in the follow-up. Thanks!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 participants
RIP legacy CRI in #9228.
The pull request is to init release upgrade testing cases to check sandbox-like CRI implementation is compatible with v1.x release. It's part of #3757