Add core and internal root packages to contributing#9445
Merged
fuweid merged 1 commit intocontainerd:mainfrom Dec 4, 2023
Merged
Add core and internal root packages to contributing#9445fuweid merged 1 commit intocontainerd:mainfrom
fuweid merged 1 commit intocontainerd:mainfrom
Conversation
fuweid
approved these changes
Dec 1, 2023
Member
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
LGTM
If here is good candidate category name for a set of packages in pkg, containerd should move the packages out of pkg. Before that, I like pkg personally, because I don't get lost in a lot of packages in root path.
dcantah
approved these changes
Dec 1, 2023
Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
update-contributing-root-packages
branch
from
4fc2d96 to
96aaf5a
Compare
estesp
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For further discussion on 2.0 package layout
Example core packages would be:
Internal package candidates would be (will be checked against pkg.go.dev reported importers):
Related to #9365