Revert "cri: make read-only mounts recursively read-only"#9747
Revert "cri: make read-only mounts recursively read-only"#9747AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
Revert PR 9713, as it appeared to break the compatibility too much kubernetes/enhancements#3858 (comment) This reverts commit b2f254f. > Conflicts: > internal/cri/opts/spec_linux_opts.go Signed-off-by: Akihiro Suda <[email protected]>
94899cb to
6670695
Compare
|
I'm asking that we have the discussion about how to handle these sorts of cases. |
I have spent almost a year to get kubernetes/enhancements#3857 approved
Now I have learnt that this was not enough, and realized a necessity to have some explicit guideline on merging potential breaking changes: |
|
Yep. I am not trying to blame you. We have a KEP that did not get the appropriate attention. We have over-burdened SIGs and maintainers. We have multiple projects with their own policies and stances on what constitutes acceptance risk. Worst, we have a clear lack of data, which makes it impossible to move forward with any real confidence, so we defaulted to the safe position. This is not a healthy place to be. Now what to do with it? I think almost everyone will agree that RRO is a better default. But changing it in the kubernetes-specific corner of containers is not the right fix. |
So, this PR reverts: I'll wait again to see if there is any chance to get the KEP approved. |
mikebrow
left a comment
There was a problem hiding this comment.
LGTM .. thx
getting harder to keep track .. made harder for us given we have to support N-different k8s releases and we've had containerd 2.0 working in main over 4-5 releases of k8s
Revert PR #9713, as it appeared to break the compatibility too much kubernetes/enhancements#3858 (comment)
This reverts commit b2f254f.