CRI: remove deprecated config properties (`auths`, `configs`, `mirrors`) by AkihiroSuda · Pull Request #9766 · containerd/containerd

AkihiroSuda · 2024-02-06T05:31:23Z

Note

The removal is likely going to be postponed to v2.1

Postpone removal of deprecated CRI config properties #9966

Remove the following config properties in /etc/containerd/config.toml:

Property Group	Property	Deprecation release	Target release for removal	Recommendation
`[plugins."io.containerd.grpc.v1.cri".registry]`	`auths`	containerd v1.3	containerd v2.0 ✅	Use `ImagePullSecrets`. See also #8228.
`[plugins."io.containerd.grpc.v1.cri".registry]`	`configs`	containerd v1.5	containerd v2.0 ✅	Use `config_path`
`[plugins."io.containerd.grpc.v1.cri".registry]`	`mirrors`	containerd v1.5	containerd v2.0 ✅	Use `config_path`

The toml properties are still kept for printing human-readable errors, but the properties will be completely removed in v2.1.

Depends on:

AkihiroSuda · 2024-02-06T05:33:10Z

cc @thockin @dims

Remove the following config properties in `/etc/containerd/config.toml`: | Property Group | Property | Deprecation release | Target release for removal | Recommendation | |-------------------------------------------------|------------|---------------------|----------------------------|------------------------| |`[plugins."io.containerd.grpc.v1.cri".registry]` | `auths` | containerd v1.3 | containerd v2.0 ✅ | Use `ImagePullSecrets` | |`[plugins."io.containerd.grpc.v1.cri".registry]` | `configs` | containerd v1.5 | containerd v2.0 ✅ | Use `config_path` | |`[plugins."io.containerd.grpc.v1.cri".registry]` | `mirrors` | containerd v1.5 | containerd v2.0 ✅ | Use `config_path` | The toml properties are still kept for printing human-readable errors, but the properties will be completely removed in v2.1. Signed-off-by: Akihiro Suda <[email protected]>

k8s-ci-robot · 2024-02-06T06:17:53Z

@AkihiroSuda: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-containerd-node-e2e	`8313a1c`	link	true	`/test pull-containerd-node-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

AkihiroSuda · 2024-02-06T06:35:56Z

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/containerd_containerd/9766/pull-containerd-node-e2e/1754745360544174080

{ failed [FAILED] Unexpected error:
    <*fmt.wrapError | 0xc0000bd900>: 
    validate service connection: validate CRI v1 runtime API for endpoint "unix:///run/containerd/containerd.sock": rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial unix /run/containerd/containerd.sock: connect: no such file or directory"
    {
        msg: "validate service connection: validate CRI v1 runtime API for endpoint \"unix:///run/containerd/containerd.sock\": rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial unix /run/containerd/containerd.sock: connect: no such file or directory\"",
        err: <*fmt.wrapError | 0xc0000bd8e0>{
            msg: "validate CRI v1 runtime API for endpoint \"unix:///run/containerd/containerd.sock\": rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial unix /run/containerd/containerd.sock: connect: no such file or directory\"",
            err: <*status.Error | 0xc0009d58f0>{
                s: {
                    s: {
                        state: {
                            NoUnkeyedLiterals: {},
                            DoNotCompare: [],
                            DoNotCopy: [],
                            atomicMessageInfo: nil,
                        },
                        sizeCache: 0,
                        unknownFields: nil,
                        Code: 14,
                        Message: "connection error: desc = \"transport: Error while dialing: dial unix /run/containerd/containerd.sock: connect: no such file or directory\"",
                        Details: nil,
                    },
                },
            },
        },
    }
occurred
In [SynchronizedBeforeSuite] at: k8s.io/kubernetes/test/e2e_node/e2e_node_suite_test.go:235 @ 02/06/24 06:17:10.719
}

samuelkarp · 2024-02-06T06:49:35Z

internal/cri/config/config.go

-		if useConfigPath {
-			return warnings, errors.New("`mirrors` cannot be set when `config_path` is provided")
-		}
-		warnings = append(warnings, deprecation.CRIRegistryMirrors)


Can you remove deprecation.CRIRegistryMirrors?

samuelkarp · 2024-02-06T06:49:51Z

internal/cri/config/config.go

 	}

-	if len(c.Registry.Configs) != 0 {
-		warnings = append(warnings, deprecation.CRIRegistryConfigs)


Can you remove deprecation.CRIRegistryConfigs?

samuelkarp · 2024-02-06T06:50:11Z

internal/cri/config/config.go

-			config.Auth = &auth
-			c.Registry.Configs[endpoint] = config
-		}
-		warnings = append(warnings, deprecation.CRIRegistryAuths)


Can you remove deprecation.CRIRegistryAuths?

don't have a replacement for cri auth yet..

see #7526 (comment)

Looks like we have to postpone removal of legacy config, although we may disable it by default and require an env var like CONTAINERD_DEPRECATED_ENABLE_CONTAINERD14_CONFIG

samuelkarp · 2024-02-06T06:52:33Z

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/containerd_containerd/9766/pull-containerd-node-e2e/1754745360544174080/artifacts/tmp-node-e2e-f8fc27d0-cos-beta-109-17800-66-81-system.log

Feb 06 06:17:06 tmp-node-e2e-f8fc27d0-cos-beta-109-17800-66-81 containerd[3207]: containerd: load required plugin io.containerd.grpc.v1.cri: unable to load CRI image service plugin dependency: invalid cri image config: `mirrors` is no longer supported since containerd v2.0, please use `config_path` instead

We'll need the prowjob to be updated to remove its use of mirrors.

adisky

registry mirrors needs to be updated at following places
https://github.com/kubernetes/test-infra/blob/master/jobs/e2e_node/containerd/config.toml#L31

https://github.com/containerd/containerd/blob/main/contrib/gce/configure.sh#L226

k8s-ci-robot · 2024-02-08T13:57:39Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AkihiroSuda · 2024-03-17T05:49:17Z

I guess we should postpone this to v2.1

github-actions · 2024-07-01T00:11:23Z

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

github-actions · 2024-07-09T00:09:51Z

This PR was closed because it has been stalled for 7 days with no activity.

AkihiroSuda added impact/changelog area/cri Container Runtime Interface (CRI) impact/breaking labels Feb 6, 2024

AkihiroSuda added this to the 2.0 milestone Feb 6, 2024

k8s-ci-robot added the size/L label Feb 6, 2024

AkihiroSuda force-pushed the remove-deprecated-cri-config branch 2 times, most recently from ac75d67 to 0ec8de1 Compare February 6, 2024 05:50

AkihiroSuda force-pushed the remove-deprecated-cri-config branch from 0ec8de1 to 8313a1c Compare February 6, 2024 05:54

samuelkarp reviewed Feb 6, 2024

View reviewed changes

adisky reviewed Feb 6, 2024

View reviewed changes

AkihiroSuda mentioned this pull request Feb 6, 2024

jobs/e2e_node/containerd: Migrate deprecated [plugins."io.containerd.grpc.v1.cri".registry.mirrors] to config_path kubernetes/test-infra#31851

Closed

adisky mentioned this pull request Feb 7, 2024

Remove containerd deprecated registry options kubernetes/test-infra#31872

Merged

k8s-ci-robot added the needs-rebase label Feb 8, 2024

AkihiroSuda marked this pull request as draft February 12, 2024 15:52

k8s-ci-robot added the do-not-merge/work-in-progress label Feb 12, 2024

AkihiroSuda mentioned this pull request Mar 5, 2024

Prepare release notes for v2.0.0-rc.0 #9735

Merged

AkihiroSuda modified the milestones: 2.0, 2.1 Mar 17, 2024

AkihiroSuda mentioned this pull request Mar 17, 2024

Postpone removal of deprecated CRI config properties #9966

Merged

github-actions bot added the Stale label Jul 1, 2024

github-actions bot closed this Jul 9, 2024

arnaldo2792 mentioned this pull request Nov 12, 2024

Upgrade containerd to v2 bottlerocket-os/bottlerocket-core-kit#256

Closed

dmcgowan removed this from the 2.1 milestone Mar 8, 2025

Conversation

AkihiroSuda commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda commented Feb 6, 2024

Uh oh!

k8s-ci-robot commented Feb 6, 2024

Uh oh!

AkihiroSuda commented Feb 6, 2024

Uh oh!

samuelkarp Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

samuelkarp Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

samuelkarp Feb 6, 2024

Choose a reason for hiding this comment

Uh oh!

mikebrow Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

mikebrow Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

mikebrow Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

samuelkarp commented Feb 6, 2024

Uh oh!

adisky left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 8, 2024

Uh oh!

AkihiroSuda commented Mar 17, 2024

Uh oh!

github-actions bot commented Jul 1, 2024

Uh oh!

github-actions bot commented Jul 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AkihiroSuda commented Feb 6, 2024 •

edited

Loading