Fix unmarshalling of registered types#53
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Nov 7, 2024
Merged
Conversation
cpuguy83
added a commit
to cpuguy83/typeurl
that referenced
this pull request
Nov 6, 2024
This is a faithful backport of containerd#53 --- In 7d3d258 I inadvterantly removed support for json unmarshalling for the case when a type implements a protobuf message but is a type that is registered. For types that are registered through the `Register` function typeurl is supposed to ignore the interfaces that the type implements and just use json. This change restores that behavior. Signed-off-by: Brian Goff <[email protected]>
In 7d3d258 I inadvterantly removed support for json unmarshalling for the case when a type implements a protobuf message but is a type that is registered. For types that are registered through the `Register` function typeurl is supposed to ignore the interfaces that the type implements and just use json. This change restores that behavior. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
main_fix_json
branch
from
af8df26 to
75963df
Compare
dmcgowan
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7d3d258 I inadvterantly removed support for json unmarshalling for the case when a type implements a protobuf message but is a type that is registered.
For types that are registered through the
Registerfunction typeurl is supposed to ignore the interfaces that the type implements and just use json.This change restores that behavior.