configure.ac: Fix selinux PKG_CHECK_MODULES#342
Closed
perfinion wants to merge 1 commit intocontainers:mainfrom
Closed
configure.ac: Fix selinux PKG_CHECK_MODULES#342perfinion wants to merge 1 commit intocontainers:mainfrom
perfinion wants to merge 1 commit intocontainers:mainfrom
Conversation
The first time PKG_CHECK_MODULES is called also checks for pkg-config. If that first call is in an optional block then later calls to PKG_CHECK_MODULES will fail. See https://autotools.io/pkgconfig/pkg_check_modules.html Section 3.4. Optional Modules Test with: This fails: ./autogen.sh --with-bash-completion-dir=/usr/share/bash-completion/completions --enable-selinux This succeeds: ./autogen.sh --with-bash-completion-dir=yes --enable-selinux Signed-off-by: Jason Zaman <[email protected]>
Author
|
Whoops, I just saw this PR which fixes the same issue: #316 Can one of these be merged? |
|
Can one of the admins verify this patch?
|
Collaborator
|
I've merged #441 which is basically the same idea as this. |
Collaborator
|
(Also, consider using the new Meson build system, available since 0.6.0, which avoids Autotools quirks by not being Autotools; the Autotools build system will probably be removed at some point.) |
zeyuwzy
added a commit
to zeyuwzy/bubblewrap-annotated
that referenced
this pull request
Nov 8, 2022
bubblewrap 0.7.0 New features: * `--size` option controls the size of a subsequent `--tmpfs` (containers#509) * Better error messages if a mount operation fails (containers#472) * Better error message if creating the new user namespace fails with `ENOSPC` (containers#487) * When building as a Meson subproject, a `RUNPATH` can be set on the executable to make it easier to bundle its `libcap` dependency Bug fixes: * When building with Autotools, ensure initial setup for `pkg-config` is not disabled by `--with-bash-completion-dir=PATH` (containers#316, containers#342, containers#441) * Fix test failures when running as uid 0 but with limited capabilities (containers#510) * Use POSIX `command -v` in preference to non-standard `which` (containers#527) * Fix a copy/paste error in `--help` (containers#531) Git-EVTag-v0-SHA512: f4f6e2a92493461c2c39bacc1c3003167162113c88d2142f2041dcb830f3bd3a7df541aad361d1e6ce99576d66bd7eac1065340406e294cd4769b9c4c81c2a2c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time PKG_CHECK_MODULES is called also checks for pkg-config.
If that first call is in an optional block then later calls to
PKG_CHECK_MODULES will fail.
See https://autotools.io/pkgconfig/pkg_check_modules.html
Section 3.4. Optional Modules
Test with:
This fails:
./autogen.sh --with-bash-completion-dir=/usr/share/bash-completion/completions --enable-selinux
This succeeds:
./autogen.sh --with-bash-completion-dir=yes --enable-selinux
Signed-off-by: Jason Zaman [email protected]