Merged
Conversation
Contributor
|
Don't see any problem with it. |
We don't need to reinvent these, especially in a confusing form (bool type like stdbool.h, but TRUE and FALSE constants like GLib). stdbool.h was available in the gcc 4.6 that is the default compiler in Ubuntu 12.04, more than a decade ago, so it seems sufficiently ubiquitous. Signed-off-by: Simon McVittie <[email protected]>
smcv
pushed a commit
to rhendric/bubblewrap
that referenced
this pull request
Oct 15, 2024
This commit adds --overlay, --tmp-overlay, --ro-overlay, and --overlay-src options to enable bubblewrap to create overlay mounts. These options are only permitted when bubblewrap is not installed setuid. Resolves: containers#412 Co-authored-by: William Manley <[email protected]> Signed-off-by: Ryan Hendrickson <[email protected]> [smcv: Fix merge conflicts with containers#660] Signed-off-by: Simon McVittie <[email protected]>
rhendric
added a commit
to rhendric/bubblewrap
that referenced
this pull request
Oct 15, 2024
This commit adds --overlay, --tmp-overlay, --ro-overlay, and --overlay-src options to enable bubblewrap to create overlay mounts. These options are only permitted when bubblewrap is not installed setuid. Resolves: containers#412 Co-authored-by: William Manley <[email protected]> Signed-off-by: Ryan Hendrickson <[email protected]> [smcv: Fix merge conflicts with containers#660] Signed-off-by: Simon McVittie <[email protected]>
rhendric
added a commit
to rhendric/bubblewrap
that referenced
this pull request
Oct 15, 2024
This commit adds --overlay, --tmp-overlay, --ro-overlay, and --overlay-src options to enable bubblewrap to create overlay mounts. These options are only permitted when bubblewrap is not installed setuid. Resolves: containers#412 Co-authored-by: William Manley <[email protected]> Signed-off-by: Ryan Hendrickson <[email protected]> [smcv: Fix merge conflicts with containers#660] Signed-off-by: Simon McVittie <[email protected]>
markyang92
added a commit
to markyang92/meta-openembedded
that referenced
this pull request
Apr 8, 2025
* backport fix from: containers/bubblewrap#660 But patch rework for this version. In gcc 15, bool became a reserved keyword in C23, causing conflicts with our custom bool definition. See also, https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 * to fix: http://errors.yoctoproject.org/Errors/Details/851183/ ../bubblewrap-0.10.0/utils.h:46:13: error: 'bool' cannot be defined via 'typedef' 46 | typedef int bool; | ^~~~ Signed-off-by: mark.yang <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 8, 2025
* backport fix from: containers/bubblewrap#660 But patch rework for this version. In gcc 15, bool became a reserved keyword in C23, causing conflicts with our custom bool definition. See also, https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 * to fix: http://errors.yoctoproject.org/Errors/Details/851183/ ../bubblewrap-0.10.0/utils.h:46:13: error: 'bool' cannot be defined via 'typedef' 46 | typedef int bool; | ^~~~ Signed-off-by: mark.yang <[email protected]> Signed-off-by: Khem Raj <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to reinvent these, especially in a confusing form (bool type like stdbool.h, but TRUE and FALSE constants like GLib). stdbool.h was available in the gcc 4.6 that is the default compiler in Ubuntu 12.04, more than a decade ago, so it seems sufficiently ubiquitous.
cc @refi64