Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

fleetd: fix argument handling#1374

Merged
jonboulle merged 1 commit intocoreos:masterfrom
jonboulle:master
Oct 12, 2015
Merged

fleetd: fix argument handling#1374
jonboulle merged 1 commit intocoreos:masterfrom
jonboulle:master

Conversation

@jonboulle
Copy link
Contributor

@jonboulle jonboulle commented Oct 12, 2015

We were calling userset.Usage but it was never actually defined. Unlike
in the top-level of the flag package (i.e. flag.Usage), this method
does not have a default value on FlagSets.

The only reason this never showed up way earlier in the ErrHelp path
(and was only revealed via 8ebb81b)
is that branch was never actually encountered.

Fixes #1360

@jonboulle
fleetd: fix argument handling
445025b 
We were calling userset.Usage but it was never actually defined. Unlike
in the top-level of the flag package (i.e. `flag.Usage`), this method
does not have a default value on `FlagSet`s.

The only reason this never showed up way earlier in the `ErrHelp` path
(and was only revealed via 8ebb81b)
is that branch was never actually encountered.
@jonboulle
Copy link
Contributor Author

jonboulle commented Oct 12, 2015 

: trevize fleet master ; bin/fleetd 
INFO fleetd.go:69: Starting fleetd version 0.11.5+git
INFO fleetd.go:175: No provided or default config file found - proceeding without
FATAL fleetd.go:97: Failed creating Server: mkdir /run/fleet: permission denied
: trevize fleet master ; bin/fleetd --version
fleetd version 0.11.5+git
: trevize fleet master ; bin/fleetd version
fleetd version 0.11.5+git
: trevize fleet master ; bin/fleetd foo
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ; bin/fleetd --false
flag provided but not defined: -false
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ; bin/fleetd asjkdlfkladsjfkladjfadslksdkl aljsdfldaks kjdkjkdkd
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ; bin/fleetd --config/tmp/asdf
flag provided but not defined: -config/tmp/asdf
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ; bin/fleetd --config=/tmp/asdf
INFO fleetd.go:69: Starting fleetd version 0.11.5+git
FATAL fleetd.go:162: Unable to use config file /tmp/asdf: stat /tmp/asdf: no such file or directory
: trevize fleet master ; bin/fleetd --help
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ; bin/fleetd -h
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ; bin/fleetd help
Usage of bin/fleetd:
  -config="": Path to config file. Fleet will look for a config at /etc/fleet/fleet.conf by default.
  -version=false: Print the version and exit
: trevize fleet master ;

@mischief
Copy link
Contributor

mischief commented Oct 12, 2015

lgtm

jonboulle added a commit that referenced this pull request Oct 12, 2015
@jonboulle
Merge pull request #1374 from jonboulle/master
b67a4d1 
fleetd: fix argument handling
@jonboulle jonboulle merged commit b67a4d1 into coreos:master Oct 12, 2015
@jonboulle jonboulle mentioned this pull request Nov 6, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/bug priority/P0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonboulle @mischief