There is no special color rule in "ls" for Executable && MultiHardLink#5
Closed
lepe wants to merge 2 commits intocoreutils:masterfrom
Closed
There is no special color rule in "ls" for Executable && MultiHardLink#5lepe wants to merge 2 commits intocoreutils:masterfrom
lepe wants to merge 2 commits intocoreutils:masterfrom
Conversation
Member
|
Thanks a lot for the patch. However I find the coloring of multiply hardlinked files quite arbitrary in the first place. Therefore colors for combinations of such attributes are even less desired IMHO. I find it much more instructive to directly highlight the interesting attribute, which is the number of links >=2 in the If you feel strongly about this, please bring it up again at [email protected] |
pixelb
added a commit
to pixelb/coreutils
that referenced
this pull request
Oct 31, 2016
This was detected in about 25% of runs with gcc -fsanitize=address
ERROR: AddressSanitizer: global-buffer-overflow on address ...
READ of size 4 at 0x000000416628 thread T0
#0 0x40479f in genpattern src/shred.c:782
coreutils#1 0x4050d9 in do_wipefd src/shred.c:921
coreutils#2 0x406203 in wipefile src/shred.c:1175
coreutils#3 0x406b84 in main src/shred.c:1316
coreutils#4 0x7f3454a1ef9f in __libc_start_main (/lib64/libc.so.6+0x1ff9f)
coreutils#5 0x4025d8 (/tmp/coreutils-8.23/src/shred+0x4025d8)
0x000000416628 is located 56 bytes to the left of
global variable '*.LC49' from 'src/shred.c' (0x416660) of size 17
0x000000416628 is located 12 bytes to the right of
global variable 'patterns' from 'src/shred.c' (0x416540) of size 220
SUMMARY: AddressSanitizer: global-buffer-overflow src/shred.c:782
* src/shred.c (gen_patterns): Restrict pattern selection
to the K available, which regressed due to v5.92-1462-g65533e1.
* tests/misc/shred-passes.sh: Add a deterministic test case.
* NEWS: Mention the bug fix.
Fixes http://bugs.gnu.org/20998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
http://unix.stackexchange.com/questions/123138/ls-color-how-to-color-executable-hard-links/247822#247822
Added: "C_EXEC_HARDLINK" and "em" (executable multihardlink) into "ls.c" code.