md5sum: Allow --zero with --check#81
Closed
ricardobranco777 wants to merge 1 commit intocoreutils:masterfrom
Closed
md5sum: Allow --zero with --check#81ricardobranco777 wants to merge 1 commit intocoreutils:masterfrom
ricardobranco777 wants to merge 1 commit intocoreutils:masterfrom
Conversation
Member
|
I'm not strongly against this, but the thinking was that md5sum itself doesn't need the --zero option when veryifying, whereas other programs could benefit from the simplified processing. I.e. by disabling --zero working with --check, we restrict checksum files to text format, without restricting any functionality So the explicit disadvantages of not restricting checksum files to text format are:
|
Author
Newer versions of md5sum should support checking files generated with --zero. It should have been done when introducing the flag. Anyway the patch is trivial and works. |
6f9e950 to
8e4d110
Compare
8e4d110 to
5d53995
Compare
Member
|
Closing on the basis of minimizing checksum file format variants |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--zerooption is useless if not supported by--check.This PR fixes it.