Skip to content

Use the actual redis connection string to connect, not the sanitized one#1141

Merged
eakraly merged 1 commit intocoturn:masterfrom
jbg:master
Jan 13, 2023
Merged

Use the actual redis connection string to connect, not the sanitized one#1141
eakraly merged 1 commit intocoturn:masterfrom
jbg:master

Conversation

@jbg
Copy link
Contributor

@jbg jbg commented Jan 11, 2023

fixes #1140

@jbg
Copy link
Contributor Author

jbg commented Jan 11, 2023

This fixes a regression introduced in af9bc12 (#1020), where coturn will try to connect to redis with a password composed entirely of asterisks.

@eakraly eakraly changed the title fix: use the actual connection string to connect, not the sanitized one Use the actual connection string to connect, not the sanitized one Jan 13, 2023
@eakraly
Copy link
Collaborator

eakraly commented Jan 13, 2023

Thank you @jbg ! That is a really dumb bug on my side :)

@eakraly eakraly changed the title Use the actual connection string to connect, not the sanitized one Use the actual redis connection string to connect, not the sanitized one Jan 13, 2023
@eakraly eakraly merged commit 8f8038a into coturn:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coturn sends the masked password (a string of asterisks) to redis and then ignores the auth failure

2 participants