Conversation
cozystack-bot
requested review from
IvanHunters,
androndo,
lexfrei,
lllamnyp and
sircthulhu
as code owners
dosubot
bot
added
the
size:M
Summary of ChangesHello @cozystack-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as a release preparation for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the v1.0.0-rc.2 release by updating various image tags and digests across the codebase. While most updates appear correct, there are several instances where image tags are updated to v1.0.0-rc.2 but their corresponding SHA256 digests remain unchanged from the previous v1.0.0-rc.1 release. This inconsistency suggests a potential issue in the build and release process for those components, as a new release tag should typically point to a new image digest reflecting the latest changes.
| @@ -1,2 +1,2 @@ | |||
| e2e: | |||
| image: ghcr.io/cozystack/cozystack/e2e-sandbox:v1.0.0-rc.1@sha256:0eae9f519669667d60b160ebb93c127843c470ad9ca3447fceaa54604503a7ba | |||
| image: ghcr.io/cozystack/cozystack/e2e-sandbox:v1.0.0-rc.2@sha256:0eae9f519669667d60b160ebb93c127843c470ad9ca3447fceaa54604503a7ba | |||
There was a problem hiding this comment.
The image tag for e2e-sandbox has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.1@sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0 | |||
| ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.2@sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0 | |||
There was a problem hiding this comment.
The image tag for objectstorage-sidecar has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
| image: ghcr.io/cozystack/cozystack/openapi-ui-k8s-bff:v1.0.0-rc.2@sha256:325de4753a9a21ebef61637c1cf32cc98559d4bc506980ce5155c11513f7dcba | ||
| tokenProxy: | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v1.0.0-rc.1@sha256:2e280991e07853ea48f97b0a42946afffa10d03d6a83d41099ed83e6ffc94fdc | ||
| image: ghcr.io/cozystack/cozystack/token-proxy:v1.0.0-rc.2@sha256:2e280991e07853ea48f97b0a42946afffa10d03d6a83d41099ed83e6ffc94fdc |
There was a problem hiding this comment.
The image tag for token-proxy has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/grafana-dashboards:v1.0.0-rc.1@sha256:7a3c9af59f8d74d5a23750bbc845c7de64610dbd4d4f84011e10be037b3ce2a0 | |||
| ghcr.io/cozystack/cozystack/grafana-dashboards:v1.0.0-rc.2@sha256:7a3c9af59f8d74d5a23750bbc845c7de64610dbd4d4f84011e10be037b3ce2a0 | |||
There was a problem hiding this comment.
The image tag for grafana-dashboards has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
| portSecurity: true | ||
| routes: "" | ||
| image: ghcr.io/cozystack/cozystack/kubeovn-webhook:v1.0.0-rc.1@sha256:e18f9fd679e38f65362a8d0042f25468272f6d081136ad47027168d8e7e07a4a | ||
| image: ghcr.io/cozystack/cozystack/kubeovn-webhook:v1.0.0-rc.2@sha256:e18f9fd679e38f65362a8d0042f25468272f6d081136ad47027168d8e7e07a4a |
There was a problem hiding this comment.
The image tag for kubeovn-webhook has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
| objectstorage: | ||
| controller: | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-controller:v1.0.0-rc.1@sha256:b4c972769afda76c48b58e7acf0ac66a0abf16a622f245c60338f432872f640a" | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-controller:v1.0.0-rc.2@sha256:b4c972769afda76c48b58e7acf0ac66a0abf16a622f245c60338f432872f640a" |
There was a problem hiding this comment.
The image tag for objectstorage-controller has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
| region: "" | ||
| sidecar: | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.1@sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0" | ||
| image: "ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.2@sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0" |
There was a problem hiding this comment.
The image tag for objectstorage-sidecar has been updated to v1.0.0-rc.2, but the digest is identical to the one from v1.0.0-rc.1. An updated release tag should correspond to a new image digest, reflecting changes in the new version. This inconsistency suggests a potential issue in the release process, where an image may not have been rebuilt or updated correctly.
📝 WalkthroughWalkthroughUpdates container image tags and SHA256 digests across multiple packages (primarily v1.0.0-rc.1 → v1.0.0-rc.2 and some digest-only bumps). No code logic, control flow, or public API declarations changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cozystack-bot
force-pushed
the
release-1.0.0-rc.2
branch
from
c10342b to
9901b64
Compare
Signed-off-by: cozystack-bot <[email protected]>
cozystack-bot
force-pushed
the
release-1.0.0-rc.2
branch
from
9901b64 to
65c6936
Compare
![coderabbitai[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/extra/seaweedfs/images/objectstorage-sidecar.tag`:
- Line 1: The image tag
ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.2 currently
references the same digest
(sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0) as
v1.0.0-rc.1; either document in the PR/release notes that rc.2 intentionally
reuses rc.1's artifact, or rebuild/publish the intended rc.2 image and update
the tag to point to the new digest for objectstorage-sidecar so the manifest
reflects the new bits.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
packages/apps/kubernetes/images/kubevirt-csi-driver.tagpackages/core/installer/values.yamlpackages/core/platform/values.yamlpackages/core/testing/values.yamlpackages/extra/bootbox/images/matchbox.tagpackages/extra/seaweedfs/images/objectstorage-sidecar.tagpackages/system/backup-controller/values.yamlpackages/system/backupstrategy-controller/values.yamlpackages/system/bucket/images/s3manager.tagpackages/system/cozystack-api/values.yamlpackages/system/cozystack-controller/values.yamlpackages/system/dashboard/templates/configmap.yamlpackages/system/dashboard/values.yamlpackages/system/grafana-operator/images/grafana-dashboards.tagpackages/system/kamaji/values.yamlpackages/system/kubeovn-plunger/values.yamlpackages/system/kubeovn-webhook/values.yamlpackages/system/kubevirt-csi-node/values.yamlpackages/system/lineage-controller-webhook/values.yamlpackages/system/linstor/values.yamlpackages/system/objectstorage-controller/values.yamlpackages/system/seaweedfs/values.yaml
✅ Files skipped from review due to trivial changes (1)
- packages/system/objectstorage-controller/values.yaml
🚧 Files skipped from review as they are similar to previous changes (15)
- packages/system/dashboard/templates/configmap.yaml
- packages/system/cozystack-controller/values.yaml
- packages/system/dashboard/values.yaml
- packages/system/kubevirt-csi-node/values.yaml
- packages/system/grafana-operator/images/grafana-dashboards.tag
- packages/system/linstor/values.yaml
- packages/system/backup-controller/values.yaml
- packages/core/testing/values.yaml
- packages/system/kubeovn-plunger/values.yaml
- packages/system/kamaji/values.yaml
- packages/core/installer/values.yaml
- packages/apps/kubernetes/images/kubevirt-csi-driver.tag
- packages/system/cozystack-api/values.yaml
- packages/system/bucket/images/s3manager.tag
- packages/system/seaweedfs/values.yaml
| @@ -1 +1 @@ | |||
| ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.1@sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0 | |||
| ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.2@sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
repo="cozystack/cozystack/objectstorage-sidecar"
for tag in v1.0.0-rc.1 v1.0.0-rc.2; do
token="$(curl -fsSL "https://ghcr.io/token?scope=repository:${repo}:pull" | jq -r '.token')"
digest="$(curl -fsSI \
-H "Authorization: Bearer ${token}" \
-H "Accept: application/vnd.oci.image.manifest.v1+json, application/vnd.docker.distribution.manifest.v2+json" \
"https://ghcr.io/v2/${repo}/manifests/${tag}" \
| tr -d '\r' | awk -F': ' 'tolower($1)=="docker-content-digest"{print $2}')"
echo "${tag} -> ${digest}"
doneRepository: cozystack/cozystack
Length of output: 236
Clarify whether v1.0.0-rc.2 should have a different digest than rc.1.
Both v1.0.0-rc.1 and v1.0.0-rc.2 point to the same digest (sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0). If this is intentional, document it in the PR or release notes. If rc.2 should contain different bits, the artifact may be stale and needs to be rebuilt.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/extra/seaweedfs/images/objectstorage-sidecar.tag` at line 1, The
image tag ghcr.io/cozystack/cozystack/objectstorage-sidecar:v1.0.0-rc.2
currently references the same digest
(sha256:235b194a531b70e266a10ef78d2955d19f5b659513f23d8b3cfbbc0dff7fc1c0) as
v1.0.0-rc.1; either document in the PR/release notes that rc.2 intentionally
reuses rc.1's artifact, or rebuild/publish the intended rc.2 image and update
the tag to point to the new digest for objectstorage-sidecar so the manifest
reflects the new bits.
2 participants
This PR prepares the release
v1.0.0-rc.2.Summary by CodeRabbit