Fixed packages name conversion in migration script#2144
Conversation
Signed-off-by: Myasnikov Daniil <[email protected]>
myasnikovdaniil
requested review from
IvanHunters,
androndo,
kvaps,
lexfrei,
lllamnyp and
sircthulhu
as code owners
dosubot
bot
added
size:XS
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughA migration script is updated to prefix items in comma-separated lists with "cozystack." when converting them to YAML arrays for both Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes the package name conversion in the migration script by adding the cozystack. prefix, which is correct. I've also provided suggestions to fix a minor issue in the awk commands that generate an extra newline, to ensure cleaner output.
![coderabbitai[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hack/migrate-to-version-1.0.sh`:
- Around line 158-164: The package-list conversion for DISABLED_PACKAGES and
ENABLED_PACKAGES blindly prepends "cozystack." to every token and doesn't trim
or skip empty tokens; update the conversion logic used for BUNDLE_DISABLE and
BUNDLE_ENABLE so it: splits on commas, trims whitespace from each token, skips
empty tokens, and only prepends "cozystack." when the token does not already
start with that prefix (preserve tokens that already include it). Locate the
conversion expressions that set DISABLED_PACKAGES and ENABLED_PACKAGES and
change their sed/awk pipeline (or replace with a small POSIX shell loop) to
perform trimming, empty-token filtering, and conditional prefixing before
emitting the " - cozystack.<pkg>" list entries.
|
Successfully created backport PR for |
2 participants
What this PR does
Release note
Summary by CodeRabbit