test: include derivation test when private key has leading zeros#9
Merged
jprichardson merged 1 commit intocryptocoinjs:masterfrom Oct 20, 2016
Merged
Conversation
Contributor
braydonf
commented
Oct 20, 2016
braydonf
commented
- Tests derivation implementation for bip32 compliance when private key has leading zeros as it's possible that the private key could be represented with less than 32 bytes. The correct implementation always uses 32 bytes for the private key in the sha512 hash.
- Uses test case added at bitcore-lib in Fix implementation of hd derivation to be bip32 compliant bitpay/bitcore-lib#97
- Test case verified against libbtc at https://github.com/braydonf/libbtc/commits/cross-ref
This was referenced Oct 20, 2016
Member
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.