Conversation
Ignore openvpn ui build files
cred service
Startup js alpine base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to make VPN startup architecture more resilient. It introduces 4 main changes:
New process structure
Global ENVs are polled, not pushed
Instead of waiting to be reseted, the VPN will poll a DAPPMANAGER API for global ENVs:
Startup script in Javascript
Write the entrypoint inside the NodeJS app, so it can be smarter and not stall. It can also report it's status via the NodeJS app to the DAPPMANAGER > ADMIN:
Deprecate the loginMsg file
Instead of waiting for a file to exist, periodically query the VPN status endpoint and eventually request the admin credentials to be generated.