simplify CGovernanceObject::GetAbsolute*Count#1026
Merged
UdjinM6 merged 1 commit intodashpay:v0.12.1.xfrom Sep 16, 2016
UdjinM6:absVotes
Merged
simplify CGovernanceObject::GetAbsolute*Count#1026UdjinM6 merged 1 commit intodashpay:v0.12.1.xfrom UdjinM6:absVotes
UdjinM6 merged 1 commit intodashpay:v0.12.1.xfrom
UdjinM6:absVotes
Conversation
|
utACK |
christiancfifi
pushed a commit
to christiancfifi/dash
that referenced
this pull request
Oct 3, 2021
…tcoin#13299) fb3ce75 Don't label transactions "Open" while catching up (Hennadii Stepanov) Pull request description: Fix bitcoin#13299. Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: dashpay#1026). This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline. Before this PR (with the issue):  With this PR (the issue has been resolved):  Tree-SHA512: 358ec83b43c266a4d32a37a79dda80e80d40a2b77ad38261c84a095e613399f674aa7184805b3f6310e51ddb83ae2636b8849fcc7c4333e1b3ecbb0f70ad86d3
christiancfifi
pushed a commit
to christiancfifi/dash
that referenced
this pull request
Oct 14, 2021
…tcoin#13299) fb3ce75 Don't label transactions "Open" while catching up (Hennadii Stepanov) Pull request description: Fix bitcoin#13299. Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: dashpay#1026). This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline. Before this PR (with the issue):  With this PR (the issue has been resolved):  Tree-SHA512: 358ec83b43c266a4d32a37a79dda80e80d40a2b77ad38261c84a095e613399f674aa7184805b3f6310e51ddb83ae2636b8849fcc7c4333e1b3ecbb0f70ad86d3
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…tcoin#13299) fb3ce75 Don't label transactions "Open" while catching up (Hennadii Stepanov) Pull request description: Fix bitcoin#13299. Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: dashpay#1026). This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline. Before this PR (with the issue):  With this PR (the issue has been resolved):  Tree-SHA512: 358ec83b43c266a4d32a37a79dda80e80d40a2b77ad38261c84a095e613399f674aa7184805b3f6310e51ddb83ae2636b8849fcc7c4333e1b3ecbb0f70ad86d3
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 4, 2022
…tcoin#13299) fb3ce75 Don't label transactions "Open" while catching up (Hennadii Stepanov) Pull request description: Fix bitcoin#13299. Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: dashpay#1026). This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline. Before this PR (with the issue):  With this PR (the issue has been resolved):  Tree-SHA512: 358ec83b43c266a4d32a37a79dda80e80d40a2b77ad38261c84a095e613399f674aa7184805b3f6310e51ddb83ae2636b8849fcc7c4333e1b3ecbb0f70ad86d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.