Conversation
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Nice! Few bits are missing however - one to fix, one to clarify (and probably to fix), see inline comments.
.travis.yml
Outdated
| - HOST=i686-pc-linux-gnu PPA="ppa:bitcoin/bitcoin" PACKAGES="g++-multilib bc python3-zmq" DEP_OPTS="NO_QT=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports LDFLAGS=-static-libstdc++" USE_SHELL="/bin/dash" PYZMQ=true | ||
| # Win64 | ||
| - HOST=x86_64-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PPA="ppa:bitcoin/bitcoin" PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports" | ||
| # bitcoind |
There was a problem hiding this comment.
:-)
I'll try to add some descriptive names later anyway, so I can change this.
.travis.yml
Outdated
| # Win64 | ||
| - HOST=x86_64-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PPA="ppa:bitcoin/bitcoin" PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports" | ||
| # bitcoind | ||
| - HOST=x86_64-unknown-linux-gnu PPA="ppa:bitcoin/bitcoin" PACKAGES="bc python3-zmq" DEP_OPTS="NO_QT=1 NO_UPNP=1 DEBUG=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports CPPFLAGS=-DDEBUG_LOCKORDER" PYZMQ=true |
| - export LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib | ||
| - if [ "$RUN_TESTS" = "true" -a "$WINE" != "true" ]; then make check; fi | ||
| - if [ "$RUN_TESTS" = "true" -a "$WINE" = "true" ]; then wine src/test/test_dash.exe && wine src/qt/test/test_dash-qt.exe ; fi | ||
| - if [ "$RUN_TESTS" = "true" ]; then make $MAKEJOBS check VERBOSE=1; fi |
There was a problem hiding this comment.
Just to clarify - no more WINE option i.e. no more Windows tests? Is this intentional?
There was a problem hiding this comment.
During my tests the wine test always failed, but that might have been side-effects of other problems.
I'll re-add them and see what happens.
|
Update: right now I cannot verify whether my fix for testing with wine works or not, because Travis times out while building some of the standard Dash dependencies (which have worked before), so I guess Travis is just under a heavy load. |
|
Looks good to me 👍 I'll try to restart windows build job a few times before merging this however to see if the issue persists. |
How do you do this without a new commit? BTW, my first wine commit complained about the headless Travis installation (no $DISPLAY), so I deployed and configured a virtual display for wine. Would be great if that works, however there are other options as well. |
|
|
Interesting... I restarted windows build jobs few times for both this (https://travis-ci.org/dashpay/dash/builds/173736623) and no DISPLAY (https://travis-ci.org/dashpay/dash/builds/173679891). The former seems to always fail, the later finishes in ~15-20 minutes, no issues. I guess it's not about heavy load, it's probably some internal travis issue. If that's true and there is no other way to enable win tests I think it's better to remove them/WINE flag/DISPLAY again for now (sorry :)) - always failing tests are meaningless anyway... Same as no tests of course but at least it will be easier to spot common errors via tests on other platforms. That's probably the reason bitcoin got them disabled, haven't check this assumption though. |
|
Interesting indeed. I'll remove the wine testing today after work so we can merge this PR, and after that I'll do more tests with my own Github repository (which is also linked to Travis) to get this resolved. |
|
On my repository all tests are green (see https://travis-ci.org/crowning-/dash/builds/174011139), here (with the same commit) the Win32 build gets stuck after 3 minutes or so (no error, just stuck), the rest runs fine. As if Travis had issues doing 2 identical builds... Anyway, @UdjinM6 could you please re-trigger the Win32 build, and if it runs okay, merge? |
2 participants
References: #1129 and #1130
With this fix our builds over at travis-ci.org should work again.
StoleTook some inspiration from several Bitcoin commits from the last couple of months, so a big "Thank you" to the Bitcoin developers.(BTW, their builds have problems as well right now :-/ bitcoin#9088 (comment))