CGovernanceManager initialization fix#1138
Merged
UdjinM6 merged 4 commits intodashpay:v0.12.1.xfrom Nov 12, 2016
Merged
Conversation
UdjinM6
reviewed
Nov 11, 2016
src/governance.cpp
Outdated
| // Ignore such messages until masternode list is synced | ||
| if(!masternodeSync.IsMasternodeListSynced()) return; | ||
| if(!masternodeSync.IsMasternodeListSynced()) { | ||
| LogPrintf("CGovernanceManager::ProcessMessage MNGOVERNANCEOBJECTVOTE -- masternode list not synced\n"); |
There was a problem hiding this comment.
this can spam a lot, I'd move this to gobject debug category
Author
There was a problem hiding this comment.
I don't think it should because we don't start syncing governance until the masternode list is synced. So I think this is more of an abnormal condition.
There was a problem hiding this comment.
This can easily be the case if at least one of our peers is in governance syncing mode (which means this node relays all received votes to us too). This multiplies with number of such peers but can quickly kill i/o even with one peer (given the fact that there will be 1000s of votes).
Author
There was a problem hiding this comment.
OK, I didn't think of that. Will change.
UdjinM6
approved these changes
Nov 11, 2016
celbalrai
added a commit
to bytzcurrency/BYTZ
that referenced
this pull request
Jul 15, 2021
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
bytzck
pushed a commit
to bytzck/BYTZ
that referenced
this pull request
Jul 20, 2021
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
ckti
added a commit
to ckti-dash-current/dash
that referenced
this pull request
Apr 7, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
ckti
pushed a commit
to ckti-dash-current/dash
that referenced
this pull request
Apr 26, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
Apr 27, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
Apr 29, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 2, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 6, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 10, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 13, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 14, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 15, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 15, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 15, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 15, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 16, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 16, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 17, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
May 23, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
Jun 14, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
wagerr-builder
pushed a commit
to wagerr-builder/wagerr
that referenced
this pull request
Jun 15, 2022
- Port and adapt PIVX commits on time protocol V2 (PR dashpay#1002) - Port PIVX commits on nTime offset warnings (PR dashpay#1138) - Adjust chain parameters - Add several copyright notices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the initialiation of CGovernanceManager that caused non-reproducible failure of governance object syncing.
The code was relying on UpdatedBlockTip to be called by new blocks but sometimes a node is restarted before any new blocks have been generated and hence this function was not called in time.
This adds a call to UpdatedBlockTip to init.cpp that should ensure that pCurrentBlockIndex is initialized.